From 4b7c108a76d26b0ebe0dd557805700a2f89109b7 Mon Sep 17 00:00:00 2001 From: Andres Rey Date: Wed, 31 Oct 2018 23:33:14 +0000 Subject: Look for classes names when checking visibility --- src/Nodes/NodeTrait.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Nodes/NodeTrait.php b/src/Nodes/NodeTrait.php index e811c12..08aa794 100644 --- a/src/Nodes/NodeTrait.php +++ b/src/Nodes/NodeTrait.php @@ -485,12 +485,12 @@ trait NodeTrait { /* * In the original JS project they check if the node has the style display=none, which unfortunately - * in our case we have no way of knowing that. So we just check for the attribute hidden. + * in our case we have no way of knowing that. So we just check for the attribute hidden or "display: none". * * Might be a good idea to check for classes or other attributes like 'aria-hidden' */ - return !$this->hasAttribute('hidden'); + return !preg_match('/display:( )?none/', $this->getAttribute('style')) && !$this->hasAttribute('hidden'); } public function isWhitespace() -- cgit v1.2.3