From 8bac6550009f575214330dc96af802a5767288c4 Mon Sep 17 00:00:00 2001 From: Andres Rey Date: Wed, 17 Oct 2018 18:52:02 +0100 Subject: Improve script node removing function --- src/Readability.php | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) (limited to 'src') diff --git a/src/Readability.php b/src/Readability.php index d44052d..2f8b22f 100644 --- a/src/Readability.php +++ b/src/Readability.php @@ -782,16 +782,10 @@ class Readability */ private function removeScripts(DOMDocument $dom) { - $toRemove = ['script', 'noscript']; - - foreach ($toRemove as $tag) { - while ($script = $dom->getElementsByTagName($tag)) { - if ($script->item(0)) { - $script->item(0)->parentNode->removeChild($script->item(0)); - } else { - break; - } - } + foreach (['script', 'noscript'] as $tag) { + $nodes = $dom->getElementsByTagName($tag); + foreach (iterator_to_array($nodes) as $node) + NodeUtility::removeNode($node); } } -- cgit v1.2.3