From 6a834e148657d20e115010d1510cd09b171ff510 Mon Sep 17 00:00:00 2001 From: Andrew Dolgov Date: Mon, 11 May 2015 11:18:27 +0300 Subject: hide actionbar when scrolling headlines on small devices do not enable ACRA on debug builds --- org.fox.ttrss/src/main/AndroidManifest.xml | 4 ++-- .../java/org/fox/ttrss/FeedCategoriesFragment.java | 5 +++++ .../src/main/java/org/fox/ttrss/FeedsActivity.java | 1 + .../src/main/java/org/fox/ttrss/FeedsFragment.java | 5 +++++ .../src/main/java/org/fox/ttrss/GlobalState.java | 5 ++++- .../main/java/org/fox/ttrss/HeadlinesFragment.java | 26 ++++++++++++++++++++-- org.fox.ttrss/src/main/res/layout/headlines.xml | 3 +-- .../main/res/layout/headlines_heading_spacer.xml | 8 +++++++ 8 files changed, 50 insertions(+), 7 deletions(-) create mode 100644 org.fox.ttrss/src/main/res/layout/headlines_heading_spacer.xml diff --git a/org.fox.ttrss/src/main/AndroidManifest.xml b/org.fox.ttrss/src/main/AndroidManifest.xml index d569cf72..9b4995d4 100755 --- a/org.fox.ttrss/src/main/AndroidManifest.xml +++ b/org.fox.ttrss/src/main/AndroidManifest.xml @@ -1,8 +1,8 @@ + android:versionCode="327" + android:versionName="1.101" > )m_cats); + if (m_activity.isSmallScreen()) { + View layout = inflater.inflate(R.layout.headlines_heading_spacer, m_list, false); + m_list.addHeaderView(layout); + } + // TODO: better check if (m_activity.findViewById(R.id.headlines_drawer) != null) { try { diff --git a/org.fox.ttrss/src/main/java/org/fox/ttrss/FeedsActivity.java b/org.fox.ttrss/src/main/java/org/fox/ttrss/FeedsActivity.java index 8b3251c8..a10c6045 100755 --- a/org.fox.ttrss/src/main/java/org/fox/ttrss/FeedsActivity.java +++ b/org.fox.ttrss/src/main/java/org/fox/ttrss/FeedsActivity.java @@ -83,6 +83,7 @@ public class FeedsActivity extends OnlineActivity implements HeadlinesEventListe public void onDrawerOpened(View drawerView) { super.onDrawerOpened(drawerView); + getSupportActionBar().show(); invalidateOptionsMenu(); } diff --git a/org.fox.ttrss/src/main/java/org/fox/ttrss/FeedsFragment.java b/org.fox.ttrss/src/main/java/org/fox/ttrss/FeedsFragment.java index 3ca1ce6e..b7f0bee6 100755 --- a/org.fox.ttrss/src/main/java/org/fox/ttrss/FeedsFragment.java +++ b/org.fox.ttrss/src/main/java/org/fox/ttrss/FeedsFragment.java @@ -287,6 +287,11 @@ public class FeedsFragment extends Fragment implements OnItemClickListener, OnSh m_list = (ListView)view.findViewById(R.id.feeds); + if (m_activity.isSmallScreen()) { + View layout = inflater.inflate(R.layout.headlines_heading_spacer, m_list, false); + m_list.addHeaderView(layout); + } + if (m_enableParentBtn) { View layout = inflater.inflate(R.layout.feeds_goback, m_list, false); diff --git a/org.fox.ttrss/src/main/java/org/fox/ttrss/GlobalState.java b/org.fox.ttrss/src/main/java/org/fox/ttrss/GlobalState.java index 7de77b69..0fc4decc 100755 --- a/org.fox.ttrss/src/main/java/org/fox/ttrss/GlobalState.java +++ b/org.fox.ttrss/src/main/java/org/fox/ttrss/GlobalState.java @@ -30,7 +30,10 @@ public class GlobalState extends Application { @Override public final void onCreate() { super.onCreate(); - ACRA.init(this); + + if (!BuildConfig.DEBUG) { + ACRA.init(this); + } m_singleton = this; } diff --git a/org.fox.ttrss/src/main/java/org/fox/ttrss/HeadlinesFragment.java b/org.fox.ttrss/src/main/java/org/fox/ttrss/HeadlinesFragment.java index a7868b0e..eaa9dfca 100755 --- a/org.fox.ttrss/src/main/java/org/fox/ttrss/HeadlinesFragment.java +++ b/org.fox.ttrss/src/main/java/org/fox/ttrss/HeadlinesFragment.java @@ -97,6 +97,7 @@ public class HeadlinesFragment extends Fragment implements OnItemClickListener, private SwipeRefreshLayout m_swipeLayout; private int m_maxImageSize = 0; private boolean m_compactLayoutMode = false; + private int m_listPreviousVisibleItem; public ArticleList getSelectedArticles() { ArticleList tmp = new ArticleList(); @@ -369,6 +370,11 @@ public class HeadlinesFragment extends Fragment implements OnItemClickListener, list.addFooterView(layout, null, false); } + if (m_activity.isSmallScreen()) { + View layout = inflater.inflate(R.layout.headlines_heading_spacer, list, false); + list.addHeaderView(layout); + } + m_adapter = new ArticleListAdapter(getActivity(), R.layout.headlines_row, (ArrayList
)m_articles); list.setAdapter(m_adapter); @@ -1315,15 +1321,31 @@ public class HeadlinesFragment extends Fragment implements OnItemClickListener, refresh(true); } - if (m_prefs.getBoolean("headlines_mark_read_scroll", false) && firstVisibleItem > 0 && !m_autoCatchupDisabled) { - Article a = m_articles.get(firstVisibleItem - 1); + if (m_prefs.getBoolean("headlines_mark_read_scroll", false) && firstVisibleItem > (m_activity.isSmallScreen() ? 1 : 0) && !m_autoCatchupDisabled) { + Article a = (Article) view.getItemAtPosition(firstVisibleItem - 1); if (a != null && a.unread) { + Log.d(TAG, "title=" + a.title); + a.unread = false; m_readArticles.add(a); m_feed.unread--; } } + + if (m_activity.isSmallScreen()) { + if (m_adapter.getCount() > 0) { + if (firstVisibleItem > m_listPreviousVisibleItem) { + m_activity.getSupportActionBar().hide(); + } else if (firstVisibleItem < m_listPreviousVisibleItem) { + m_activity.getSupportActionBar().show(); + } + } else { + m_activity.getSupportActionBar().show(); + } + + m_listPreviousVisibleItem = firstVisibleItem; + } } @Override diff --git a/org.fox.ttrss/src/main/res/layout/headlines.xml b/org.fox.ttrss/src/main/res/layout/headlines.xml index 226928d4..f1865cd3 100755 --- a/org.fox.ttrss/src/main/res/layout/headlines.xml +++ b/org.fox.ttrss/src/main/res/layout/headlines.xml @@ -1,7 +1,6 @@ + android:layout_height="fill_parent"> + + + + \ No newline at end of file -- cgit v1.2.3