From 0a7826c93c9af48244bd267f458eb8c0af815210 Mon Sep 17 00:00:00 2001 From: Andrew Gaul Date: Sun, 31 Jan 2021 15:45:29 +0900 Subject: Make some inner classes static This avoids an implicit this field and can help GC. Found via error-prone. --- .../src/main/java/org/fox/ttrss/FeedCategoriesFragment.java | 6 +++--- org.fox.ttrss/src/main/java/org/fox/ttrss/FeedsFragment.java | 6 +++--- org.fox.ttrss/src/main/java/org/fox/ttrss/GalleryActivity.java | 4 ++-- org.fox.ttrss/src/main/java/org/fox/ttrss/OnlineActivity.java | 2 +- .../src/main/java/org/fox/ttrss/share/SubscribeActivity.java | 6 +++--- 5 files changed, 12 insertions(+), 12 deletions(-) (limited to 'org.fox.ttrss') diff --git a/org.fox.ttrss/src/main/java/org/fox/ttrss/FeedCategoriesFragment.java b/org.fox.ttrss/src/main/java/org/fox/ttrss/FeedCategoriesFragment.java index dedc1b4b..a63913a2 100755 --- a/org.fox.ttrss/src/main/java/org/fox/ttrss/FeedCategoriesFragment.java +++ b/org.fox.ttrss/src/main/java/org/fox/ttrss/FeedCategoriesFragment.java @@ -175,7 +175,7 @@ public class FeedCategoriesFragment extends BaseFeedlistFragment implements OnIt } @SuppressLint("DefaultLocale") - class CatUnreadComparator implements Comparator { + static class CatUnreadComparator implements Comparator { @Override public int compare(FeedCategory a, FeedCategory b) { if (a.unread != b.unread) @@ -187,7 +187,7 @@ public class FeedCategoriesFragment extends BaseFeedlistFragment implements OnIt @SuppressLint("DefaultLocale") - class CatTitleComparator implements Comparator { + static class CatTitleComparator implements Comparator { @Override public int compare(FeedCategory a, FeedCategory b) { @@ -200,7 +200,7 @@ public class FeedCategoriesFragment extends BaseFeedlistFragment implements OnIt } @SuppressLint("DefaultLocale") - class CatOrderComparator implements Comparator { + static class CatOrderComparator implements Comparator { @Override public int compare(FeedCategory a, FeedCategory b) { diff --git a/org.fox.ttrss/src/main/java/org/fox/ttrss/FeedsFragment.java b/org.fox.ttrss/src/main/java/org/fox/ttrss/FeedsFragment.java index dde7923e..d73e80d8 100755 --- a/org.fox.ttrss/src/main/java/org/fox/ttrss/FeedsFragment.java +++ b/org.fox.ttrss/src/main/java/org/fox/ttrss/FeedsFragment.java @@ -195,7 +195,7 @@ public class FeedsFragment extends BaseFeedlistFragment implements OnItemClickLi } @SuppressLint("DefaultLocale") - class FeedUnreadComparator implements Comparator { + static class FeedUnreadComparator implements Comparator { @Override public int compare(Feed a, Feed b) { @@ -209,7 +209,7 @@ public class FeedsFragment extends BaseFeedlistFragment implements OnItemClickLi @SuppressLint("DefaultLocale") - class FeedTitleComparator implements Comparator { + static class FeedTitleComparator implements Comparator { @Override public int compare(Feed a, Feed b) { @@ -228,7 +228,7 @@ public class FeedsFragment extends BaseFeedlistFragment implements OnItemClickLi } @SuppressLint("DefaultLocale") - class FeedOrderComparator implements Comparator { + static class FeedOrderComparator implements Comparator { @Override public int compare(Feed a, Feed b) { diff --git a/org.fox.ttrss/src/main/java/org/fox/ttrss/GalleryActivity.java b/org.fox.ttrss/src/main/java/org/fox/ttrss/GalleryActivity.java index 8bd7ed38..dff6fe41 100755 --- a/org.fox.ttrss/src/main/java/org/fox/ttrss/GalleryActivity.java +++ b/org.fox.ttrss/src/main/java/org/fox/ttrss/GalleryActivity.java @@ -47,7 +47,7 @@ public class GalleryActivity extends CommonActivity { private ViewPager m_pager; private ProgressBar m_checkProgress; - private class ArticleImagesPagerAdapter extends FragmentStatePagerAdapter { + private static class ArticleImagesPagerAdapter extends FragmentStatePagerAdapter { private List m_items; public ArticleImagesPagerAdapter(FragmentManager fm, List items) { @@ -90,7 +90,7 @@ public class GalleryActivity extends CommonActivity { } } - private class MediaProgressResult { + private static class MediaProgressResult { GalleryEntry item; int position; int count; diff --git a/org.fox.ttrss/src/main/java/org/fox/ttrss/OnlineActivity.java b/org.fox.ttrss/src/main/java/org/fox/ttrss/OnlineActivity.java index 04e31a99..1ad51a9a 100755 --- a/org.fox.ttrss/src/main/java/org/fox/ttrss/OnlineActivity.java +++ b/org.fox.ttrss/src/main/java/org/fox/ttrss/OnlineActivity.java @@ -146,7 +146,7 @@ public class OnlineActivity extends CommonActivity { //protected PullToRefreshAttacher m_pullToRefreshAttacher; - protected abstract class OnLoginFinishedListener { + protected static abstract class OnLoginFinishedListener { public abstract void OnLoginSuccess(); public abstract void OnLoginFailed(); } diff --git a/org.fox.ttrss/src/main/java/org/fox/ttrss/share/SubscribeActivity.java b/org.fox.ttrss/src/main/java/org/fox/ttrss/share/SubscribeActivity.java index 9b92630a..c25784b5 100755 --- a/org.fox.ttrss/src/main/java/org/fox/ttrss/share/SubscribeActivity.java +++ b/org.fox.ttrss/src/main/java/org/fox/ttrss/share/SubscribeActivity.java @@ -46,7 +46,7 @@ public class SubscribeActivity extends CommonShareActivity { private static final int REQ_CATS = 1; private static final int REQ_POST = 2; - class CatTitleComparator implements Comparator { + static class CatTitleComparator implements Comparator { @Override public int compare(FeedCategory a, FeedCategory b) { @@ -333,7 +333,7 @@ public class SubscribeActivity extends CommonShareActivity { } } - private class CatListAdapter extends ArrayAdapter { + private static class CatListAdapter extends ArrayAdapter { private List m_items; public CatListAdapter(Context context, int resource, @@ -362,7 +362,7 @@ public class SubscribeActivity extends CommonShareActivity { } } - private class FeedListAdapter extends ArrayAdapter { + private static class FeedListAdapter extends ArrayAdapter { private List> m_items; public FeedListAdapter(Context context, int resource, List> items) { -- cgit v1.2.3