#10 New "Always open external links" preference

Merged
fox merged 3 commits from Aevnar/master into fox/master 2 weeks ago
Aevnar commented 3 weeks ago
  • Added a new preference "Always open external links" that changes the default behavior of selecting an article
  • Activating this preference will make it so that the "Open with..." command is invoked directly when selecting an article, instead of opening the default detail view
  • The long-press menu on articles remain usable and unchanged
- Added a new preference "Always open external links" that changes the default behavior of selecting an article - Activating this preference will make it so that the "Open with..." command is invoked directly when selecting an article, instead of opening the default detail view - The long-press menu on articles remain usable and unchanged
fox commented 3 weeks ago
Owner

everything is largely agreeable except for this:

+    <string name="prefs_always_open_uri">Always open external links</string>
+    <string name="prefs_always_open_uri_summary">Selecting an article will automatically trigger the \'Open with&#8230;\' command</string

this sounds terrible and should be rephrased. i'm not sure how but as a starting point something like

  1. Open articles directly
  2. Opens articles in your web browser, instead of going to detail view

i don't like the second one but that's the general gist of it. ideas? we're not "opening links with open with".

e: i'm also not sure about simply increasing settings bloat.

everything is largely agreeable except for this: ``` + <string name="prefs_always_open_uri">Always open external links</string> + <string name="prefs_always_open_uri_summary">Selecting an article will automatically trigger the \'Open with&#8230;\' command</string ``` this sounds terrible and should be rephrased. i'm not sure how but as a starting point something like 1. Open articles directly 2. Opens articles in your web browser, instead of going to detail view i don't like the second one but that's the general gist of it. ideas? we're not "opening links with open with". e: i'm also not sure about simply increasing settings bloat.
Aevnar commented 2 weeks ago
Poster

I changed the wording to something closer to what you suggested. As for settings bloat, I don't think it's that bad, comparing to other readers which have 3 times that in multiple settings pages. I do not think we should label bloat what I would consider a useful feature, as it enables a more efficient workflow for people used to having this feature in other readers.

I changed the wording to something closer to what you suggested. As for settings bloat, I don't think it's that bad, comparing to other readers which have 3 times that in multiple settings pages. I do not think we should label bloat what I would consider a useful feature, as it enables a more efficient workflow for people used to having this feature in other readers.
fox commented 2 weeks ago
Owner

this is a lot better, i think the first one can be shortened further to "Always open in browser".

comparing to other readers which have 3 times that in multiple settings pages

some people like having an abundance of options, i dunno why but my pet theory is this giving them an illusion of control otherwise missing from their daily life

personally i prefer sane defaults :)

this is a lot better, i think the first one can be shortened further to "Always open in browser". >comparing to other readers which have 3 times that in multiple settings pages some people like having an abundance of options, i dunno why but my pet theory is this giving them an illusion of control otherwise missing from their daily life personally i prefer sane defaults :)
Aevnar commented 2 weeks ago
Poster

There you go. I agree that oftentimes less is more, but in this case, it's the kind of option which enables a different workflow which alot of people have gotten used to, and not just some "background color" type of preference ;)

There you go. I agree that oftentimes less is more, but in this case, it's the kind of option which enables a different workflow which alot of people have gotten used to, and not just some "background color" type of preference ;)
fox commented 2 weeks ago
Owner

very nice. i think preferences should be reshuffled somewhat with some stuff moved into dedicated "Headlines" section but this can wait until later

very nice. i think preferences should be reshuffled somewhat with some stuff moved into dedicated "Headlines" section but this can wait until later
This pull request has been merged successfully!
Sign in to join this conversation.
No Label
No Milestone
No assignee
2 Participants
Loading...
Cancel
Save
There is no content yet.