Try to limit max favicon size, don't store current/old in a var.

1 files changed, 8 insertions, 4 deletions

diff --git a/classes/rssutils.php b/classes/rssutils.php
index 13f63bc7a..6785ab3f5 100755
--- a/classes/rssutils.php
+++ b/classes/rssutils.php
@@ -1652,15 +1652,19 @@ class RSSUtils {
 		}
 
 		// Limiting to "image" type misses those served with text/plain
-		$contents = UrlHelper::fetch(['url' => $favicon_url]); // , "image");
+		$contents = UrlHelper::fetch([
+			'url' => $favicon_url,
+			'max_size' => MAX_FAVICON_FILE_SIZE,
+			//'type' => 'image',
+		]);
 		if (!$contents) {
 			Debug::log("fetching favicon $favicon_url failed", Debug::$LOG_VERBOSE);
 			return false;
 		}
 
-		$original_contents = file_exists($icon_file) ? file_get_contents($icon_file) : null;
-		if ($original_contents) {
-			if (strcmp($contents, $original_contents) === 0) {
+		$original_contents_md5 = file_exists($icon_file) ? md5_file($icon_file) : null;
+		if ($original_contents_md5) {
+			if (md5($contents) == $original_contents_md5) {
 				Debug::log("favicon content has not changed", Debug::$LOG_VERBOSE);
 				return $icon_file;
 			}