summaryrefslogtreecommitdiff
path: root/functions.js
diff options
context:
space:
mode:
authorAndrew Dolgov <[email protected]>2008-04-18 06:13:00 +0100
committerAndrew Dolgov <[email protected]>2008-04-18 06:13:00 +0100
commit06925d9e8502e544a98b7b2dacf618be9e34f25f (patch)
tree08fb7deaec41b3adb0b60f9186d691be7792e248 /functions.js
parentae56f762746c1854acd326802cea7cc5f36244e7 (diff)
getArticleLink: add escaping; open_article_in_new_window: add error notifications (closes #202)
Diffstat (limited to 'functions.js')
-rw-r--r--functions.js9
1 files changed, 9 insertions, 0 deletions
diff --git a/functions.js b/functions.js
index 9e38e45b0..d30e6bee8 100644
--- a/functions.js
+++ b/functions.js
@@ -68,10 +68,15 @@ function open_article_callback(transport) {
try {
if (transport.responseXML) {
+
var link = transport.responseXML.getElementsByTagName("link")[0];
var id = transport.responseXML.getElementsByTagName("id")[0];
+ debug("open_article_callback, received link: " + link);
+
if (link) {
+ debug("link url: " + link.firstChild.nodeValue);
+
window.open(link.firstChild.nodeValue, "_blank");
if (id) {
@@ -80,7 +85,11 @@ function open_article_callback(transport) {
window.setTimeout("toggleUnread(" + id + ", 0)", 100);
}
}
+ } else {
+ notify_error("Can't open article: received invalid article link");
}
+ } else {
+ notify_error("Can't open article: received invalid XML");
}
} catch (e) {