diff options
author | Andrew Dolgov <[email protected]> | 2017-04-26 20:57:36 +0300 |
---|---|---|
committer | Andrew Dolgov <[email protected]> | 2017-04-26 20:57:36 +0300 |
commit | 21ce7d9ec02b0bf7c6e0ac7c28bc7c1bb0a841c5 (patch) | |
tree | 2a784cf4c91abe828b42e79a886c2cc0f80df5e2 /plugins/af_redditimgur | |
parent | ea79a0e033e40057279a7f464c9464145eedc932 (diff) |
update phpmd ruleset to use (subset) of cleancode
fix various minor issues reported by static analysis
remove redundant php closing tag from several more files
Diffstat (limited to 'plugins/af_redditimgur')
-rwxr-xr-x | plugins/af_redditimgur/init.php | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/plugins/af_redditimgur/init.php b/plugins/af_redditimgur/init.php index aa3ef59bb..d08dfa7a6 100755 --- a/plugins/af_redditimgur/init.php +++ b/plugins/af_redditimgur/init.php @@ -73,6 +73,9 @@ class Af_RedditImgur extends Plugin { echo __("Configuration saved"); } + /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + */ private function inline_stuff($article, &$doc, $xpath, $debug = false) { $entries = $xpath->query('(//a[@href]|//img[@src])'); @@ -442,13 +445,16 @@ class Af_RedditImgur extends Plugin { curl_setopt($ch, CURLOPT_FOLLOWLOCATION, !ini_get("open_basedir")); curl_setopt($ch, CURLOPT_USERAGENT, $useragent); - @$result = curl_exec($ch); + @curl_exec($ch); $content_type = curl_getinfo($ch, CURLINFO_CONTENT_TYPE); } return $content_type; } + /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + */ private function readability($article, $url, $doc, $xpath, $debug = false) { if (!defined('NO_CURL') && function_exists("curl_init") && $this->host->get($this, "enable_readability") && @@ -510,4 +516,3 @@ class Af_RedditImgur extends Plugin { return $article; } } -?> |