remove some plugin JS code out of global context

2 files changed, 20 insertions, 25 deletions

diff --git a/plugins/note/init.php b/plugins/note/init.php
index 354591b75..ac908a5ba 100644
--- a/plugins/note/init.php
+++ b/plugins/note/init.php
@@ -24,7 +24,7 @@ class Note extends Plugin {
 	function hook_article_button($line) {
 		return "<img src=\"plugins/note/note.png\"
 			style=\"cursor : pointer\" style=\"cursor : pointer\"
-			onclick=\"editArticleNote(".$line["id"].")\"
+			onclick=\"Plugins.Note.edit(".$line["id"].")\"
 			class='tagsPic' title='".__('Edit article note')."'>";
 	}
 
diff --git a/plugins/note/note.js b/plugins/note/note.js
index 836481c40..21c1ae51e 100644
--- a/plugins/note/note.js
+++ b/plugins/note/note.js
@@ -1,46 +1,41 @@
-function editArticleNote(id) {
-	try {
-
-		var query = "backend.php?op=pluginhandler&plugin=note&method=edit&param=" + encodeURIComponent(id);
+Plugins.Note = {
+	edit: function(id) {
+		const query = "backend.php?op=pluginhandler&plugin=note&method=edit&param=" + encodeURIComponent(id);
 
 		if (dijit.byId("editNoteDlg"))
 			dijit.byId("editNoteDlg").destroyRecursive();
 
-		dialog = new dijit.Dialog({
+		const dialog = new dijit.Dialog({
 			id: "editNoteDlg",
 			title: __("Edit article note"),
 			style: "width: 600px",
-			execute: function() {
+			execute: function () {
 				if (this.validate()) {
 					Notify.progress("Saving article note...", true);
 
 					xhrJson("backend.php", this.attr('value'), (reply) => {
-                        Notify.close();
-                        dialog.hide();
+						Notify.close();
+						dialog.hide();
 
-                        if (reply) {
-                            ArticleCache.del(id);
+						if (reply) {
+							ArticleCache.del(id);
 
-                            var elem = $("POSTNOTE-" + id);
+							var elem = $("POSTNOTE-" + id);
 
-                            if (elem) {
-                                Element.hide(elem);
-                                elem.innerHTML = reply.note;
+							if (elem) {
+								Element.hide(elem);
+								elem.innerHTML = reply.note;
 
-                                if (reply.raw_length != 0)
-                                    new Effect.Appear(elem);
-                            }
-                        }
-                    });
+								if (reply.raw_length != 0)
+									new Effect.Appear(elem);
+							}
+						}
+					});
 				}
 			},
 			href: query,
 		});
 
 		dialog.show();
-
-	} catch (e) {
-		exception_error("editArticleNote", e);
 	}
-}
-
+};
\ No newline at end of file