offline: properly close resultsets with rs.close()

1 files changed, 24 insertions, 4 deletions

diff --git a/viewfeed.js b/viewfeed.js
index 7aaa7f77b..d4967aefa 100644
--- a/viewfeed.js
+++ b/viewfeed.js
@@ -1520,11 +1520,16 @@ function cache_find(id) {
 
 	if (db) {
 		var rs = db.execute("SELECT article FROM cache WHERE id = ?", [id]);
+		var a = false;
 
 		if (rs.isValidRow()) {
-			return rs.field(0);
+			var a = rs.field(0);			
 		}
 
+		rs.close();
+
+		return a;
+
 	} else {
 		for (var i = 0; i < article_cache.length; i++) {
 			if (article_cache[i]["id"] == id) {
@@ -1540,11 +1545,16 @@ function cache_find_param(id, param) {
 	if (db) {
 		var rs = db.execute("SELECT article FROM cache WHERE id = ? AND param = ?",
 			[id, param]);
+		var a = false;
 
 		if (rs.isValidRow()) {
-			return rs.field(0);
+			a = rs.field(0);
 		}
 
+		rs.close();
+
+		return a;
+
 	} else {
 		for (var i = 0; i < article_cache.length; i++) {
 			if (article_cache[i]["id"] == id && article_cache[i]["param"] == param) {
@@ -1560,11 +1570,16 @@ function cache_check(id) {
 	if (db) {
 		var rs = db.execute("SELECT COUNT(*) AS c FROM cache WHERE id = ?",
 			[id]);
+		var a = false;
 
 		if (rs.isValidRow()) {
-			return rs.field(0) != "0";
+			 a = rs.field(0) != "0";
 		}
 
+		rs.close();
+
+		return a;
+
 	} else {
 		for (var i = 0; i < article_cache.length; i++) {
 			if (article_cache[i]["id"] == id) {
@@ -1580,11 +1595,16 @@ function cache_check_param(id, param) {
 	if (db) {
 		var rs = db.execute("SELECT COUNT(*) AS c FROM cache WHERE id = ? AND param = ?",
 			[id, param]);
+		var a = false;
 
 		if (rs.isValidRow()) {
-			return rs.field(0) != "0";
+			a = rs.field(0) != "0";
 		}
 
+		rs.close();
+
+		return a;
+
 	} else {
 		for (var i = 0; i < article_cache.length; i++) {
 			if (article_cache[i]["id"] == id && article_cache[i]["param"] == param) {