Age | Commit message (Collapse) | Author |
|
|
|
|
|
Also some minor related tweaks in other classes.
|
|
|
|
Also related changes in some other classes.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
This also includes some minor tweaks to things that call 'Sanitizer::sanitize()'.
|
|
This also includes a minor tweak in 'update.php' to account for 'getopt()' potentially returning false (indicating failure).
|
|
|
|
|
|
|
|
'update_daemon2.php'.
This ensures both are of the expected type (int) and meet a reasonable minimum.
|
|
|
|
|
|
|
|
|
|
- read only - can't subscribe to more feeds, feed updates are skipped
- disabled - can't login
define used access levels as UserHelper constants and refactor code to
use them instead of hardcoded numbers
|
|
wn/tt-rss:feature/phpstan-1.0.0-and-fixes into master
Reviewed-on: https://git.tt-rss.org/fox/tt-rss/pulls/49
|
|
------ --------------------------------------
Line update.php
------ --------------------------------------
213 While loop condition is always true.
------ --------------------------------------
|
|
------ ------------------------------------------------------------------
Line include/colors.php
------ ------------------------------------------------------------------
215 Variable $out might not be defined.
223 Parameter #3 $pad_string of function str_pad expects string, int
given.
255 Variable $h might not be defined.
317 Variable $img might not be defined.
------ ------------------------------------------------------------------
|
|
Intentionally skipping the line 66 one for now; adding an 'is_array' check clears the warning, but there's a larger topic of how to handle an invalid '' that doesn't result in an array.
------ ---------------------------------------------------------------------
Line classes/urlhelper.php
------ ---------------------------------------------------------------------
66 Offset 'path' on array{scheme: string} in isset() does not exist.
165 Parameter #2 $associative of function get_headers expects bool, int
given.
167 Parameter #2 $associative of function get_headers expects bool, int
given.
278 Negated boolean expression is always true.
309 Negated boolean expression is always true.
------ ---------------------------------------------------------------------
|
|
------ -------------------------------
Line classes/pref/users.php
------ -------------------------------
170 If condition is always false.
------ -------------------------------
|
|
------ ------------------------------------------------
Line classes/pref/prefs.php
------ ------------------------------------------------
1328 Expression on left side of ?? is not nullable.
------ ------------------------------------------------
|
|
------ --------------------------------------------------------------------
Line classes/pluginhost.php
------ --------------------------------------------------------------------
16 Property PluginHost::$last_registered is never read, only written.
386 If condition is always true.
------ --------------------------------------------------------------------
|
|
------ --------------------------------------
Line classes/logger/sql.php
------ --------------------------------------
4 Property Logger_SQL::$pdo is unused.
------ --------------------------------------
|
|
------ ------------------------------------
Line classes/feeds.php
------ ------------------------------------
8 Property Feeds::$params is unused.
------ ------------------------------------
|
|
------ ---------------------------------------------
Line classes/feeditem/common.php
------ ---------------------------------------------
194 No error to ignore is reported on line 194.
------ ---------------------------------------------
|
|
------ --------------------------------------------------
Line classes/db.php
------ --------------------------------------------------
7 Property Db::$link is unused.
86 Property Db::pdo (PDO) in empty() is not falsy.
------ --------------------------------------------------
|
|
------ -----------------------------------------------------------------------
Line classes/config.php
------ -----------------------------------------------------------------------
3 Constant Config::_ENVVAR_PREFIX is unused.
177 Constant Config::_DEFAULTS is unused.
237 Property Config::$schema_version is never read, only written.
352 Property Config::$migrations (Db_Migrations) in empty() is not falsy.
------ -----------------------------------------------------------------------
|
|
|
|
|
|
its actually there
|
|
backend: pass plugin button generated code through domdocument to ensure
its correctness; set data-plugin-name attribute on children to make
them sortable via css
|
|
|
|
|
|
(rewriting to reddit.com)
|
|
HOOK_PRE_SUBSCRIBE
|
|
|
|
|