Age | Commit message (Collapse) | Author | |
---|---|---|---|
2021-11-13 | set some annotations on Plugin hook methods | Andrew Dolgov | |
2021-11-13 | experimental: bring back plugin hooks to Plugin base class once (to be ↵ | Andrew Dolgov | |
improved/fixed with annotations later) | |||
2021-11-13 | deal with some warnings in plugins/trgm,readability and base plugin class | Andrew Dolgov | |
2021-11-13 | no need to duplicate annotations | Andrew Dolgov | |
2021-11-13 | rework previous Plugin changes as phpdoc annotations | Andrew Dolgov | |
2021-11-13 | revert all plugin base class related changes to keep compatibility with ↵ | Andrew Dolgov | |
extant plugins (for the time being) | |||
2021-11-13 | minor: correct $cat type in Pref_Feeds#calculate_children_count() | wn_ | |
2021-11-13 | Address PHPStan warnings in 'classes/pref/feeds.php'. | wn_ | |
2021-11-13 | Fix the type of Labels::update_cache() | wn_ | |
2021-11-13 | fix phpstan warnings in classes/plugin-template.php | Andrew Dolgov | |
2021-11-13 | experimental: also don't keep base plugin template as a non-analyzed file | Andrew Dolgov | |
2021-11-13 | experimental: auto-generate and add all plugin hook methods to Plugin class | Andrew Dolgov | |
2021-11-13 | fix phpstan warnings in classes/sanitizer.php | Andrew Dolgov | |
2021-11-13 | fix phpstan warnings in classes/api.php | Andrew Dolgov | |
2021-11-13 | fix phpstan warnings in classes/feedparser.php | Andrew Dolgov | |
2021-11-13 | fix phpstan warnings in classes/db/migrations.php | Andrew Dolgov | |
2021-11-13 | Address PHPStan warnings in 'classes/api.php'. | wn_ | |
2021-11-13 | Typing IHandler methods, typing Handler_Public, fix type of $feed_id (might ↵ | wn_ | |
be tag). | |||
2021-11-13 | Fix type of 'check_first_id' in Feeds '_format_headlines_list'. | wn_ | |
2021-11-12 | Switch class properties from PHP typing to PHPDoc for compatibility with PHP ↵ | wn_ | |
< 7.4.0 | |||
2021-11-12 | Address PHPStan warnings in 'classes/mailer.php', 'classes/opml.php', and ↵ | wn_ | |
'classes/pluginhandler.php'. | |||
2021-11-12 | Address PHPStan warnings in 'classes/rpc.php'. | wn_ | |
Also a couple minor fixes in 'classes/article.php' and 'classes/labels.php'. | |||
2021-11-12 | Fix some PHPStan warnings in 'classes/db/migrations.php', ↵ | wn_ | |
'classes/db/prefs.php', and 'classes/debug.php'. | |||
2021-11-12 | Fix a warning in 'classes/counters.php'. | wn_ | |
2021-11-12 | Address PHPStan warnings in 'classes/feeds.php'. | wn_ | |
Also some minor related tweaks in other classes. | |||
2021-11-12 | Update signature of handler 'csrf_ignore' to include types. | wn_ | |
2021-11-12 | Address PHPStan warnings in 'classes/article.php'. | wn_ | |
Also related changes in some other classes. | |||
2021-11-12 | Address PHPStan warnings in 'classes/pluginhost.php'. | wn_ | |
2021-11-11 | Address PHPStan warnings in 'classes/labels.php'. | wn_ | |
2021-11-11 | Address PHPStan warnings in 'classes/diskcache.php'. | wn_ | |
2021-11-11 | Address PHPStan warnings in 'inclasses/digest.php'. | wn_ | |
2021-11-11 | Fix 'TimeHelper::make_local_datetime()' (null is allowed). | wn_ | |
2021-11-11 | Address PHPStan warnings in 'classes/debug.php'. | wn_ | |
2021-11-11 | Address PHPStan warnings in 'classes/userhelper.php'. | wn_ | |
2021-11-11 | Address PHPStan warnings in 'classes/timehelper.php'. | wn_ | |
2021-11-11 | Address PHPStan warnings in 'classes/sanitizer.php'. | wn_ | |
This also includes some minor tweaks to things that call 'Sanitizer::sanitize()'. | |||
2021-11-11 | Address PHPStan warnings in 'classes/rssutils.php'. | wn_ | |
This also includes a minor tweak in 'update.php' to account for 'getopt()' potentially returning false (indicating failure). | |||
2021-11-11 | Address PHPStan warnings in 'classes/prefs.php'. | wn_ | |
2021-11-11 | Address PHPStan warnings in 'classes/counters.php'. | wn_ | |
2021-11-11 | Fix some additional PHPStan warnings in UrlHelper. | wn_ | |
2021-11-10 | Initial go at PHPStan rule level 6. | wn_ | |
2021-11-10 | add two helper account access levels: | Andrew Dolgov | |
- read only - can't subscribe to more feeds, feed updates are skipped - disabled - can't login define used access levels as UserHelper constants and refactor code to use them instead of hardcoded numbers | |||
2021-11-01 | Address PHPStan warnings in 'classes/urlhelper.php'. | wn_ | |
Intentionally skipping the line 66 one for now; adding an 'is_array' check clears the warning, but there's a larger topic of how to handle an invalid '' that doesn't result in an array. ------ --------------------------------------------------------------------- Line classes/urlhelper.php ------ --------------------------------------------------------------------- 66 Offset 'path' on array{scheme: string} in isset() does not exist. 165 Parameter #2 $associative of function get_headers expects bool, int given. 167 Parameter #2 $associative of function get_headers expects bool, int given. 278 Negated boolean expression is always true. 309 Negated boolean expression is always true. ------ --------------------------------------------------------------------- | |||
2021-11-01 | Address PHPStan warning in 'classes/pref/users.php'. | wn_ | |
------ ------------------------------- Line classes/pref/users.php ------ ------------------------------- 170 If condition is always false. ------ ------------------------------- | |||
2021-11-01 | Address PHPStan warning in 'classes/pref/prefs.php'. | wn_ | |
------ ------------------------------------------------ Line classes/pref/prefs.php ------ ------------------------------------------------ 1328 Expression on left side of ?? is not nullable. ------ ------------------------------------------------ | |||
2021-11-01 | Address PHPStan warnings in 'classes/pluginhost.php'. | wn_ | |
------ -------------------------------------------------------------------- Line classes/pluginhost.php ------ -------------------------------------------------------------------- 16 Property PluginHost::$last_registered is never read, only written. 386 If condition is always true. ------ -------------------------------------------------------------------- | |||
2021-11-01 | Address PHPStan warning in 'classes/logger/sql.php'. | wn_ | |
------ -------------------------------------- Line classes/logger/sql.php ------ -------------------------------------- 4 Property Logger_SQL::$pdo is unused. ------ -------------------------------------- | |||
2021-11-01 | Address PHPStan warning in 'classes/feeds.php'. | wn_ | |
------ ------------------------------------ Line classes/feeds.php ------ ------------------------------------ 8 Property Feeds::$params is unused. ------ ------------------------------------ | |||
2021-11-01 | Address PHPStan warning in 'classes/feeditem/common.php'. | wn_ | |
------ --------------------------------------------- Line classes/feeditem/common.php ------ --------------------------------------------- 194 No error to ignore is reported on line 194. ------ --------------------------------------------- | |||
2021-11-01 | Address PHPStan warnings in 'classes/db.php'. | wn_ | |
------ -------------------------------------------------- Line classes/db.php ------ -------------------------------------------------- 7 Property Db::$link is unused. 86 Property Db::pdo (PDO) in empty() is not falsy. ------ -------------------------------------------------- |