summaryrefslogtreecommitdiff
path: root/classes
AgeCommit message (Collapse)Author
2021-11-13Address PHPStan warnings in 'classes/pref/feeds.php'.wn_
2021-11-13Fix the type of Labels::update_cache()wn_
2021-11-13fix phpstan warnings in classes/plugin-template.phpAndrew Dolgov
2021-11-13experimental: also don't keep base plugin template as a non-analyzed fileAndrew Dolgov
2021-11-13experimental: auto-generate and add all plugin hook methods to Plugin classAndrew Dolgov
2021-11-13fix phpstan warnings in classes/sanitizer.phpAndrew Dolgov
2021-11-13fix phpstan warnings in classes/api.phpAndrew Dolgov
2021-11-13fix phpstan warnings in classes/feedparser.phpAndrew Dolgov
2021-11-13fix phpstan warnings in classes/db/migrations.phpAndrew Dolgov
2021-11-13Address PHPStan warnings in 'classes/api.php'.wn_
2021-11-13Typing IHandler methods, typing Handler_Public, fix type of $feed_id (might ↵wn_
be tag).
2021-11-13Fix type of 'check_first_id' in Feeds '_format_headlines_list'.wn_
2021-11-12Switch class properties from PHP typing to PHPDoc for compatibility with PHP ↵wn_
< 7.4.0
2021-11-12Address PHPStan warnings in 'classes/mailer.php', 'classes/opml.php', and ↵wn_
'classes/pluginhandler.php'.
2021-11-12Address PHPStan warnings in 'classes/rpc.php'.wn_
Also a couple minor fixes in 'classes/article.php' and 'classes/labels.php'.
2021-11-12Fix some PHPStan warnings in 'classes/db/migrations.php', ↵wn_
'classes/db/prefs.php', and 'classes/debug.php'.
2021-11-12Fix a warning in 'classes/counters.php'.wn_
2021-11-12Address PHPStan warnings in 'classes/feeds.php'.wn_
Also some minor related tweaks in other classes.
2021-11-12Update signature of handler 'csrf_ignore' to include types.wn_
2021-11-12Address PHPStan warnings in 'classes/article.php'.wn_
Also related changes in some other classes.
2021-11-12Address PHPStan warnings in 'classes/pluginhost.php'.wn_
2021-11-11Address PHPStan warnings in 'classes/labels.php'.wn_
2021-11-11Address PHPStan warnings in 'classes/diskcache.php'.wn_
2021-11-11Address PHPStan warnings in 'inclasses/digest.php'.wn_
2021-11-11Fix 'TimeHelper::make_local_datetime()' (null is allowed).wn_
2021-11-11Address PHPStan warnings in 'classes/debug.php'.wn_
2021-11-11Address PHPStan warnings in 'classes/userhelper.php'.wn_
2021-11-11Address PHPStan warnings in 'classes/timehelper.php'.wn_
2021-11-11Address PHPStan warnings in 'classes/sanitizer.php'.wn_
This also includes some minor tweaks to things that call 'Sanitizer::sanitize()'.
2021-11-11Address PHPStan warnings in 'classes/rssutils.php'.wn_
This also includes a minor tweak in 'update.php' to account for 'getopt()' potentially returning false (indicating failure).
2021-11-11Address PHPStan warnings in 'classes/prefs.php'.wn_
2021-11-11Address PHPStan warnings in 'classes/counters.php'.wn_
2021-11-11Fix some additional PHPStan warnings in UrlHelper.wn_
2021-11-10Initial go at PHPStan rule level 6.wn_
2021-11-10add two helper account access levels:Andrew Dolgov
- read only - can't subscribe to more feeds, feed updates are skipped - disabled - can't login define used access levels as UserHelper constants and refactor code to use them instead of hardcoded numbers
2021-11-01Address PHPStan warnings in 'classes/urlhelper.php'.wn_
Intentionally skipping the line 66 one for now; adding an 'is_array' check clears the warning, but there's a larger topic of how to handle an invalid '' that doesn't result in an array. ------ --------------------------------------------------------------------- Line classes/urlhelper.php ------ --------------------------------------------------------------------- 66 Offset 'path' on array{scheme: string} in isset() does not exist. 165 Parameter #2 $associative of function get_headers expects bool, int given. 167 Parameter #2 $associative of function get_headers expects bool, int given. 278 Negated boolean expression is always true. 309 Negated boolean expression is always true. ------ ---------------------------------------------------------------------
2021-11-01Address PHPStan warning in 'classes/pref/users.php'.wn_
------ ------------------------------- Line classes/pref/users.php ------ ------------------------------- 170 If condition is always false. ------ -------------------------------
2021-11-01Address PHPStan warning in 'classes/pref/prefs.php'.wn_
------ ------------------------------------------------ Line classes/pref/prefs.php ------ ------------------------------------------------ 1328 Expression on left side of ?? is not nullable. ------ ------------------------------------------------
2021-11-01Address PHPStan warnings in 'classes/pluginhost.php'.wn_
------ -------------------------------------------------------------------- Line classes/pluginhost.php ------ -------------------------------------------------------------------- 16 Property PluginHost::$last_registered is never read, only written. 386 If condition is always true. ------ --------------------------------------------------------------------
2021-11-01Address PHPStan warning in 'classes/logger/sql.php'.wn_
------ -------------------------------------- Line classes/logger/sql.php ------ -------------------------------------- 4 Property Logger_SQL::$pdo is unused. ------ --------------------------------------
2021-11-01Address PHPStan warning in 'classes/feeds.php'.wn_
------ ------------------------------------ Line classes/feeds.php ------ ------------------------------------ 8 Property Feeds::$params is unused. ------ ------------------------------------
2021-11-01Address PHPStan warning in 'classes/feeditem/common.php'.wn_
------ --------------------------------------------- Line classes/feeditem/common.php ------ --------------------------------------------- 194 No error to ignore is reported on line 194. ------ ---------------------------------------------
2021-11-01Address PHPStan warnings in 'classes/db.php'.wn_
------ -------------------------------------------------- Line classes/db.php ------ -------------------------------------------------- 7 Property Db::$link is unused. 86 Property Db::pdo (PDO) in empty() is not falsy. ------ --------------------------------------------------
2021-11-01Address PHPStan warnings in 'classes/config.php'.wn_
------ ----------------------------------------------------------------------- Line classes/config.php ------ ----------------------------------------------------------------------- 3 Constant Config::_ENVVAR_PREFIX is unused. 177 Constant Config::_DEFAULTS is unused. 237 Property Config::$schema_version is never read, only written. 352 Property Config::$migrations (Db_Migrations) in empty() is not falsy. ------ -----------------------------------------------------------------------
2021-10-26HOOK_ARTICLE_BUTTON/HOOK_ARTICLE_LEFT_BUTTON: only try to parse markup if ↵Andrew Dolgov
its actually there
2021-10-24css: make plugin button container a flexboxAndrew Dolgov
backend: pass plugin button generated code through domdocument to ensure its correctness; set data-plugin-name attribute on children to make them sortable via css
2021-10-22minor phpstan tweaksAndrew Dolgov
2021-10-22pluginhost: update comments for HOOK_ constants to use phpdoc syntax; add ↵Andrew Dolgov
HOOK_PRE_SUBSCRIBE
2021-10-15Fix undefined array key "output" when adding new labelPhilip Klempin
2021-10-15OPML improvements/fixes:Andrew Dolgov
* allow CLI import of OPML files (--opml-import) * visualize OPML structure when importing * add strict type hints to most OPML class methods