From 8727fb3ba8a28da48c71bdd39166b9aeb3c3d986 Mon Sep 17 00:00:00 2001 From: wn_ Date: Mon, 8 Jan 2024 22:46:13 +0000 Subject: Clean up some unused variables. This is essentially https://gitlab.tt-rss.org/wn/tt-rss/-/commit/1ccc0c8c1af04dd9654b585c6d07e3a75d944a0c without the renames and some other things related to Psalm. --- classes/Pref_Prefs.php | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'classes/Pref_Prefs.php') diff --git a/classes/Pref_Prefs.php b/classes/Pref_Prefs.php index c9eb89631..6985c49e4 100644 --- a/classes/Pref_Prefs.php +++ b/classes/Pref_Prefs.php @@ -1223,13 +1223,10 @@ class Pref_Prefs extends Handler_Protected { $proc = proc_open("git clone " . escapeshellarg($plugin['clone_url']) . " " . $tmp_dir, $descriptorspec, $pipes, sys_get_temp_dir()); - $status = 0; - if (is_resource($proc)) { $rv["stdout"] = stream_get_contents($pipes[1]); $rv["stderr"] = stream_get_contents($pipes[2]); - $status = proc_close($proc); - $rv["git_status"] = $status; + $rv["git_status"] = proc_close($proc); // yeah I know about mysterious RC = -1 if (file_exists("$tmp_dir/init.php")) { @@ -1546,7 +1543,7 @@ class Pref_Prefs extends Handler_Protected { } function deleteAppPasswords(): void { - $passwords = ORM::for_table('ttrss_app_passwords') + ORM::for_table('ttrss_app_passwords') ->where('owner_uid', $_SESSION['uid']) ->where_in('id', $_REQUEST['ids'] ?? []) ->delete_many(); -- cgit v1.2.3