From f2323bda81a8fb4f80fff043b356449ef0233305 Mon Sep 17 00:00:00 2001
From: Andrew Dolgov <noreply@fakecake.org>
Date: Sat, 13 Nov 2021 18:26:11 +0300
Subject: fix phpstan warnings in classes/plugin-template.php

---
 classes/plugin.php | 26 +++++++++++++++-----------
 1 file changed, 15 insertions(+), 11 deletions(-)

(limited to 'classes/plugin.php')

diff --git a/classes/plugin.php b/classes/plugin.php
index 1b6702d72..08a122023 100644
--- a/classes/plugin.php
+++ b/classes/plugin.php
@@ -5,53 +5,57 @@ abstract class Plugin {
 	/** @var PDO $pdo */
 	protected $pdo;
 
-	abstract function init(PluginHost $host);
+	abstract function init(PluginHost $host) : void;
 
-	abstract function about();
+	/** @return array<float|string|bool> */
+	abstract function about() : array;
 	// return array(1.0, "plugin", "No description", "No author", false);
 
 	function __construct() {
 		$this->pdo = Db::pdo();
 	}
 
-	function flags() {
+	/** @return array<string,int> */
+	function flags() : array {
 		/* associative array, possible keys:
 			needs_curl = boolean
 		*/
 		return array();
 	}
 
-	function is_public_method($method) {
+	function is_public_method(string $method) : bool {
 		return false;
 	}
 
-	function csrf_ignore($method) {
+	function csrf_ignore(string $method) : bool {
 		return false;
 	}
 
-	function get_js() {
+	function get_js() : string {
 		return "";
 	}
 
-	function get_prefs_js() {
+	function get_prefs_js() : string {
 		return "";
 	}
 
-	function api_version() {
+	function api_version() : int {
 		return Plugin::API_VERSION_COMPAT;
 	}
 
 	/* gettext-related helpers */
 
-	function __($msgid) {
+	function __(string $msgid) : string {
+		/** @var Plugin $this -- this is a strictly template-related hack */
 		return _dgettext(PluginHost::object_to_domain($this), $msgid);
 	}
 
-	function _ngettext($singular, $plural, $number) {
+	function _ngettext(string $singular, string $plural, int $number) : string {
+		/** @var Plugin $this -- this is a strictly template-related hack */
 		return _dngettext(PluginHost::object_to_domain($this), $singular, $plural, $number);
 	}
 
-	function T_sprintf() {
+	function T_sprintf() : string {
 		$args = func_get_args();
 		$msgid = array_shift($args);
 
-- 
cgit v1.2.3