From 7c6f7bb0aa50f42fd697fbe82dc9b8b5931a3a52 Mon Sep 17 00:00:00 2001
From: Andrew Dolgov <noreply@fakecake.org>
Date: Sun, 3 Dec 2017 23:08:04 +0300
Subject: fix some minor issues found by code analyzer

---
 classes/pref/feeds.php   | 18 ------------------
 classes/pref/filters.php |  8 --------
 classes/pref/prefs.php   |  1 -
 3 files changed, 27 deletions(-)

(limited to 'classes/pref')

diff --git a/classes/pref/feeds.php b/classes/pref/feeds.php
index 5b7e52ac0..05f6b8c8f 100755
--- a/classes/pref/feeds.php
+++ b/classes/pref/feeds.php
@@ -1212,24 +1212,6 @@ class Pref_Feeds extends Handler_Protected {
 		print $error_button;
 		print $inactive_button;
 
-		if (defined('_ENABLE_FEED_DEBUGGING')) {
-
-			print "<select id=\"feedActionChooser\" onchange=\"feedActionChange()\">
-				<option value=\"facDefault\" selected>".__('More actions...')."</option>";
-
-			if (FORCE_ARTICLE_PURGE == 0) {
-				print
-					"<option value=\"facPurge\">".__('Manual purge')."</option>";
-			}
-
-			print "
-				<option value=\"facClear\">".__('Clear feed data')."</option>
-				<option value=\"facRescore\">".__('Rescore articles')."</option>";
-
-			print "</select>";
-
-		}
-
 		print "</div>"; # toolbar
 
 		//print '</div>';
diff --git a/classes/pref/filters.php b/classes/pref/filters.php
index e1c2e776d..1ff9a3723 100755
--- a/classes/pref/filters.php
+++ b/classes/pref/filters.php
@@ -762,12 +762,6 @@ class Pref_Filters extends Handler_Protected {
 
 	function index() {
 
-		$sort = $_REQUEST["sort"];
-
-		if (!$sort || $sort == "undefined") {
-			$sort = "reg_exp";
-		}
-
 		$filter_search = $_REQUEST["search"];
 
 		if (array_key_exists("search", $_REQUEST)) {
@@ -780,8 +774,6 @@ class Pref_Filters extends Handler_Protected {
 		print "<div id=\"pref-filter-header\" dojoType=\"dijit.layout.ContentPane\" region=\"top\">";
 		print "<div id=\"pref-filter-toolbar\" dojoType=\"dijit.Toolbar\">";
 
-		$filter_search = $_REQUEST["search"];
-
 		if (array_key_exists("search", $_REQUEST)) {
 			$_SESSION["prefs_filter_search"] = $filter_search;
 		} else {
diff --git a/classes/pref/prefs.php b/classes/pref/prefs.php
index 03563d8b0..5d999bf3d 100644
--- a/classes/pref/prefs.php
+++ b/classes/pref/prefs.php
@@ -99,7 +99,6 @@ class Pref_Prefs extends Handler_Protected {
 
 		foreach (array_keys($_POST) as $pref_name) {
 
-			$pref_name = $pref_name;
 			$value = $_POST[$pref_name];
 
 			if ($pref_name == 'DIGEST_PREFERRED_TIME') {
-- 
cgit v1.2.3