From c48dd6a3c4f68d1a3980bfed0d4d827fada92c32 Mon Sep 17 00:00:00 2001 From: wn_ Date: Sun, 5 Mar 2023 14:02:26 +0000 Subject: Address PHPStan 'right side always true' in FeedItem_RSS. --- classes/feeditem/rss.php | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) (limited to 'classes') diff --git a/classes/feeditem/rss.php b/classes/feeditem/rss.php index e07fd1d06..b5710ef4f 100755 --- a/classes/feeditem/rss.php +++ b/classes/feeditem/rss.php @@ -84,15 +84,6 @@ class FeedItem_RSS extends FeedItem_Common { /** @var DOMElement|null */ $contentB = $this->elem->getElementsByTagName("description")->item(0); - if ($contentA && !$contentB) { - return $this->subtree_or_text($contentA); - } - - - if ($contentB && !$contentA) { - return $this->subtree_or_text($contentB); - } - if ($contentA && $contentB) { $resultA = $this->subtree_or_text($contentA); $resultB = $this->subtree_or_text($contentB); @@ -100,6 +91,14 @@ class FeedItem_RSS extends FeedItem_Common { return mb_strlen($resultA) > mb_strlen($resultB) ? $resultA : $resultB; } + if ($contentA) { + return $this->subtree_or_text($contentA); + } + + if ($contentB) { + return $this->subtree_or_text($contentB); + } + return ''; } -- cgit v1.2.3