From 98af46addd0978c0a8d6893f16a9b46d548b06e7 Mon Sep 17 00:00:00 2001 From: Andrew Dolgov Date: Sun, 14 Nov 2021 16:13:06 +0300 Subject: prefs: properly report failures when loading plugin list --- js/PrefHelpers.js | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'js/PrefHelpers.js') diff --git a/js/PrefHelpers.js b/js/PrefHelpers.js index 30a4544fe..ce3046210 100644 --- a/js/PrefHelpers.js +++ b/js/PrefHelpers.js @@ -363,8 +363,15 @@ const Helpers = { xhr.json("backend.php", {op: "pref-prefs", method: "getPluginsList"}, (reply) => { this._list_of_plugins = reply; this.render_contents(); + }, (e) => { + this.render_error(e); }); }, + render_error: function(e) { + const container = document.querySelector(".prefs-plugin-list"); + + container.innerHTML = `
  • ${__("Error while loading plugins list: %s.").replace("%s", e)}
    • `; + }, render_contents: function() { const container = document.querySelector(".prefs-plugin-list"); -- cgit v1.2.3 From 8cd69fe15c72982ad44d0ce5ba4b1454028408b5 Mon Sep 17 00:00:00 2001 From: Andrew Dolgov Date: Mon, 15 Nov 2021 20:18:37 +0300 Subject: when uninstall plugins, refresh plugins index instead of reloading entire prefs pane --- js/PrefHelpers.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'js/PrefHelpers.js') diff --git a/js/PrefHelpers.js b/js/PrefHelpers.js index ce3046210..c0fff66c9 100644 --- a/js/PrefHelpers.js +++ b/js/PrefHelpers.js @@ -457,7 +457,7 @@ const Helpers = { xhr.json("backend.php", {op: "pref-prefs", method: "uninstallPlugin", plugin: plugin}, (reply) => { if (reply && reply.status == 1) - Helpers.Prefs.refresh(); + Helpers.Plugins.reload(); else { Notify.error("Plugin uninstallation failed."); } -- cgit v1.2.3