From 1bfe1d7b31d5202846beb3425039776fbdbbfb85 Mon Sep 17 00:00:00 2001
From: Andrew Dolgov <noreply@fakecake.org>
Date: Sat, 4 Mar 2017 14:34:44 +0300
Subject: simplify error handling

* less convoluted exception dialogs
* use window.onerror for the majority of exception catching/reporting
* remove most of now useless try/catch blocks
* report stacktrace instead of manually specified error locations
---
 js/feedlist.js | 650 +++++++++++++++++++++++++--------------------------------
 1 file changed, 290 insertions(+), 360 deletions(-)

(limited to 'js/feedlist.js')

diff --git a/js/feedlist.js b/js/feedlist.js
index 6d37377a4..941fe9e8b 100644
--- a/js/feedlist.js
+++ b/js/feedlist.js
@@ -8,253 +8,226 @@ var _viewfeed_timeout = false;
 var counters_last_request = 0;
 var _counters_prev = [];
 
-/*function viewCategory(cat) {
-	viewfeed({feed: cat, is_cat: true});
-	return false;
-}*/
-
 function resetCounterCache() {
 	_counters_prev = [];
 }
 
 function loadMoreHeadlines() {
-	try {
-		console.log("loadMoreHeadlines");
-
-		var offset = 0;
-
-		var view_mode = document.forms["main_toolbar_form"].view_mode.value;
-		var unread_in_buffer = $$("#headlines-frame > div[id*=RROW][class*=Unread]").length;
-		var num_all = $$("#headlines-frame > div[id*=RROW]").length;
-		var num_unread = getFeedUnread(getActiveFeedId(), activeFeedIsCat());
-
-		// TODO implement marked & published
-
-		if (view_mode == "marked") {
-			console.warn("loadMoreHeadlines: marked is not implemented, falling back.");
-			offset = num_all;
-		} else if (view_mode == "published") {
-			console.warn("loadMoreHeadlines: published is not implemented, falling back.");
-			offset = num_all;
-		} else if (view_mode == "unread") {
-			offset = unread_in_buffer;
-		} else if (_search_query) {
-			offset = num_all;
-		} else if (view_mode == "adaptive" && !(getActiveFeedId() == -1 && !activeFeedIsCat())) {
-			// ^ starred feed shows both unread & read articles in adaptive mode
-			offset = num_unread > 0 ? unread_in_buffer : num_all;
-		} else {
-			offset = num_all;
-		}
+	console.log("loadMoreHeadlines");
+
+	var offset = 0;
+
+	var view_mode = document.forms["main_toolbar_form"].view_mode.value;
+	var unread_in_buffer = $$("#headlines-frame > div[id*=RROW][class*=Unread]").length;
+	var num_all = $$("#headlines-frame > div[id*=RROW]").length;
+	var num_unread = getFeedUnread(getActiveFeedId(), activeFeedIsCat());
+
+	// TODO implement marked & published
+
+	if (view_mode == "marked") {
+		console.warn("loadMoreHeadlines: marked is not implemented, falling back.");
+		offset = num_all;
+	} else if (view_mode == "published") {
+		console.warn("loadMoreHeadlines: published is not implemented, falling back.");
+		offset = num_all;
+	} else if (view_mode == "unread") {
+		offset = unread_in_buffer;
+	} else if (_search_query) {
+		offset = num_all;
+	} else if (view_mode == "adaptive" && !(getActiveFeedId() == -1 && !activeFeedIsCat())) {
+		// ^ starred feed shows both unread & read articles in adaptive mode
+		offset = num_unread > 0 ? unread_in_buffer : num_all;
+	} else {
+		offset = num_all;
+	}
 
-		console.log("offset: " + offset);
+	console.log("offset: " + offset);
 
-		viewfeed({feed: getActiveFeedId(), is_cat: activeFeedIsCat(), offset: offset, infscroll_req: true});
+	viewfeed({feed: getActiveFeedId(), is_cat: activeFeedIsCat(), offset: offset, infscroll_req: true});
 
-	} catch (e) {
-		exception_error("viewNextFeedPage", e);
-	}
 }
 
 function cleanup_memory(root) {
-	try {
-		var dijits = dojo.query("[widgetid]", dijit.byId(root).domNode).map(dijit.byNode);
+	var dijits = dojo.query("[widgetid]", dijit.byId(root).domNode).map(dijit.byNode);
 
-		dijits.each(function (d) {
-			dojo.destroy(d.domNode);
-		});
+	dijits.each(function (d) {
+		dojo.destroy(d.domNode);
+	});
 
-		$$("#" + root + " *").each(function (i) {
-			i.parentNode ? i.parentNode.removeChild(i) : true;
-		});
-	} catch (e) {
-		console.log("cleanup_memory: exception");
-		console.log(e);
-	}
+	$$("#" + root + " *").each(function (i) {
+		i.parentNode ? i.parentNode.removeChild(i) : true;
+	});
 }
 
 function viewfeed(params) {
-	try {
-		var feed = params.feed;
-		var is_cat = params.is_cat;
-		var offset = params.offset;
-		var background = params.background;
-		var infscroll_req = params.infscroll_req;
-		var can_wait = params.can_wait;
-		var viewfeed_debug = params.viewfeed_debug;
-		var method = params.method;
-
-		if (is_cat == undefined)
-			is_cat = false;
-		else
-			is_cat = !!is_cat;
-
-		if (offset == undefined) offset = 0;
-		if (background == undefined) background = false;
-		if (infscroll_req == undefined) infscroll_req = false;
-
-		last_requested_article = 0;
-
-		if (feed != getActiveFeedId() || activeFeedIsCat() != is_cat) {
-			if (!background && _search_query) _search_query = false;
-		}
-
-		if (!background) {
-			_viewfeed_last = get_timestamp();
+	var feed = params.feed;
+	var is_cat = params.is_cat;
+	var offset = params.offset;
+	var background = params.background;
+	var infscroll_req = params.infscroll_req;
+	var can_wait = params.can_wait;
+	var viewfeed_debug = params.viewfeed_debug;
+	var method = params.method;
+
+	if (is_cat == undefined)
+		is_cat = false;
+	else
+		is_cat = !!is_cat;
+
+	if (offset == undefined) offset = 0;
+	if (background == undefined) background = false;
+	if (infscroll_req == undefined) infscroll_req = false;
+
+	last_requested_article = 0;
+
+	if (feed != getActiveFeedId() || activeFeedIsCat() != is_cat) {
+		if (!background && _search_query) _search_query = false;
+	}
 
-			if (getActiveFeedId() != feed || !infscroll_req) {
-				setActiveArticleId(0);
-				_infscroll_disable = 0;
+	if (!background) {
+		_viewfeed_last = get_timestamp();
 
-				cleanup_memory("headlines-frame");
-				_headlines_scroll_offset = 0;
-			}
+		if (getActiveFeedId() != feed || !infscroll_req) {
+			setActiveArticleId(0);
+			_infscroll_disable = 0;
 
-			if (infscroll_req) {
-				var timestamp = get_timestamp();
+			cleanup_memory("headlines-frame");
+			_headlines_scroll_offset = 0;
+		}
 
-				if (_infscroll_request_sent && _infscroll_request_sent + 30 > timestamp) {
-					//console.log("infscroll request in progress, aborting");
-					return;
-				}
+		if (infscroll_req) {
+			var timestamp = get_timestamp();
 
-				_infscroll_request_sent = timestamp;
+			if (_infscroll_request_sent && _infscroll_request_sent + 30 > timestamp) {
+				//console.log("infscroll request in progress, aborting");
+				return;
 			}
+
+			_infscroll_request_sent = timestamp;
 		}
+	}
 
-		Form.enable("main_toolbar_form");
+	Form.enable("main_toolbar_form");
 
-		var toolbar_query = Form.serialize("main_toolbar_form");
+	var toolbar_query = Form.serialize("main_toolbar_form");
 
-		var query = "?op=feeds&method=view&feed=" + param_escape(feed) + "&" +
-			toolbar_query;
+	var query = "?op=feeds&method=view&feed=" + param_escape(feed) + "&" +
+		toolbar_query;
 
-		if (method) query += "&m=" + param_escape(method);
+	if (method) query += "&m=" + param_escape(method);
 
-		if (offset > 0) {
-			if (current_first_id) {
-				query = query + "&fid=" + param_escape(current_first_id);
-			}
+	if (offset > 0) {
+		if (current_first_id) {
+			query = query + "&fid=" + param_escape(current_first_id);
 		}
+	}
 
-		if (!background) {
-			if (_search_query) {
-				force_nocache = true;
-				query = query + "&" + _search_query;
-				//_search_query = false;
-			}
+	if (!background) {
+		if (_search_query) {
+			force_nocache = true;
+			query = query + "&" + _search_query;
+			//_search_query = false;
+		}
 
-			if (offset != 0) {
-				query = query + "&skip=" + offset;
+		if (offset != 0) {
+			query = query + "&skip=" + offset;
 
-				// to prevent duplicate feed titles when showing grouped vfeeds
-				if (vgroup_last_feed) {
-					query = query + "&vgrlf=" + param_escape(vgroup_last_feed);
-				}
-			} else {
-				if (!is_cat && feed == getActiveFeedId() && !params.method) {
-					query = query + "&m=ForceUpdate";
-				}
+			// to prevent duplicate feed titles when showing grouped vfeeds
+			if (vgroup_last_feed) {
+				query = query + "&vgrlf=" + param_escape(vgroup_last_feed);
 			}
+		} else {
+			if (!is_cat && feed == getActiveFeedId() && !params.method) {
+				query = query + "&m=ForceUpdate";
+			}
+		}
 
-			Form.enable("main_toolbar_form");
+		Form.enable("main_toolbar_form");
 
-			if (!setFeedExpandoIcon(feed, is_cat,
-				(is_cat) ? 'images/indicator_tiny.gif' : 'images/indicator_white.gif'))
-					notify_progress("Loading, please wait...", true);
-		}
+		if (!setFeedExpandoIcon(feed, is_cat,
+			(is_cat) ? 'images/indicator_tiny.gif' : 'images/indicator_white.gif'))
+				notify_progress("Loading, please wait...", true);
+	}
 
-		query += "&cat=" + is_cat;
+	query += "&cat=" + is_cat;
 
-		console.log(query);
+	console.log(query);
 
-		if (can_wait && _viewfeed_timeout) {
-			setFeedExpandoIcon(getActiveFeedId(), activeFeedIsCat(), 'images/blank_icon.gif');
-			clearTimeout(_viewfeed_timeout);
-		}
+	if (can_wait && _viewfeed_timeout) {
+		setFeedExpandoIcon(getActiveFeedId(), activeFeedIsCat(), 'images/blank_icon.gif');
+		clearTimeout(_viewfeed_timeout);
+	}
 
-		setActiveFeedId(feed, is_cat);
+	setActiveFeedId(feed, is_cat);
 
-		if (viewfeed_debug) {
-			window.open("backend.php" + query + "&debug=1&csrf_token=" + getInitParam("csrf_token"));
-		}
+	if (viewfeed_debug) {
+		window.open("backend.php" + query + "&debug=1&csrf_token=" + getInitParam("csrf_token"));
+	}
 
-		timeout_ms = can_wait ? 250 : 0;
-		_viewfeed_timeout = setTimeout(function() {
+	timeout_ms = can_wait ? 250 : 0;
+	_viewfeed_timeout = setTimeout(function() {
 
-			new Ajax.Request("backend.php", {
-				parameters: query,
-				onComplete: function(transport) {
+		new Ajax.Request("backend.php", {
+			parameters: query,
+			onComplete: function(transport) {
+				try {
 					setFeedExpandoIcon(feed, is_cat, 'images/blank_icon.gif');
 					headlines_callback2(transport, offset, background, infscroll_req);
 					PluginHost.run(PluginHost.HOOK_FEED_LOADED, [feed, is_cat]);
-				} });
-		}, timeout_ms); // Wait 250ms
+				} catch (e) {
+					exception_error(e);
+				}
+			} });
+	}, timeout_ms); // Wait 250ms
 
-	} catch (e) {
-		exception_error("viewfeed", e);
-	}
 }
 
 function feedlist_init() {
-	try {
-		console.log("in feedlist init");
+	console.log("in feedlist init");
 
-		loading_set_progress(50);
+	loading_set_progress(50);
 
-		document.onkeydown = hotkey_handler;
-		setTimeout(hotkey_prefix_timeout, 5*1000);
+	document.onkeydown = hotkey_handler;
+	setTimeout(hotkey_prefix_timeout, 5*1000);
 
-		if (!getActiveFeedId()) {
-			viewfeed({feed: -3});
-		} else {
- 			viewfeed({feed: getActiveFeedId(), is_cat: activeFeedIsCat()});
-		}
+	if (!getActiveFeedId()) {
+		viewfeed({feed: -3});
+	} else {
+		viewfeed({feed: getActiveFeedId(), is_cat: activeFeedIsCat()});
+	}
 
-		hideOrShowFeeds(getInitParam("hide_read_feeds") == 1);
+	hideOrShowFeeds(getInitParam("hide_read_feeds") == 1);
 
-		request_counters(true);
-		timeout();
+	request_counters(true);
+	timeout();
 
-	} catch (e) {
-		exception_error("feedlist/init", e);
-	}
 }
 
 
 function request_counters(force) {
-	try {
-		var date = new Date();
-		var timestamp = Math.round(date.getTime() / 1000);
-
-		if (force || timestamp - counters_last_request > 5) {
-			console.log("scheduling request of counters...");
+	var date = new Date();
+	var timestamp = Math.round(date.getTime() / 1000);
 
-			counters_last_request = timestamp;
+	if (force || timestamp - counters_last_request > 5) {
+		console.log("scheduling request of counters...");
 
-			var query = "?op=rpc&method=getAllCounters&seq=" + next_seq();
+		counters_last_request = timestamp;
 
-			if (!force)
-				query = query + "&last_article_id=" + getInitParam("last_article_id");
+		var query = "?op=rpc&method=getAllCounters&seq=" + next_seq();
 
-			console.log(query);
+		if (!force)
+			query = query + "&last_article_id=" + getInitParam("last_article_id");
 
-			new Ajax.Request("backend.php", {
-				parameters: query,
-				onComplete: function(transport) {
-					try {
-						handle_rpc_json(transport);
-					} catch (e) {
-						exception_error("request_counters", e);
-					}
-				} });
+		console.log(query);
 
-		} else {
-			console.log("request_counters: rate limit reached: " + (timestamp - counters_last_request));
-		}
+		new Ajax.Request("backend.php", {
+			parameters: query,
+			onComplete: function(transport) {
+				handle_rpc_json(transport);
+			} });
 
-	} catch (e) {
-		exception_error("request_counters", e);
+	} else {
+		console.log("request_counters: rate limit reached: " + (timestamp - counters_last_request));
 	}
 }
 
@@ -289,61 +262,56 @@ function counter_is_equal(a, b) {
 
 
 function parse_counters(elems) {
-	try {
-		for (var l = 0; l < elems.length; l++) {
+	for (var l = 0; l < elems.length; l++) {
 
-			if (_counters_prev[l] && counter_is_equal(elems[l], _counters_prev[l])) {
-				continue;
-			}
+		if (_counters_prev[l] && counter_is_equal(elems[l], _counters_prev[l])) {
+			continue;
+		}
 
-			var id = elems[l].id;
-			var kind = elems[l].kind;
-			var ctr = parseInt(elems[l].counter);
-			var error = elems[l].error;
-			var has_img = elems[l].has_img;
-			var updated = elems[l].updated;
-			var auxctr = parseInt(elems[l].auxcounter);
-
-			if (id == "global-unread") {
-				global_unread = ctr;
-				updateTitle();
-				continue;
-			}
+		var id = elems[l].id;
+		var kind = elems[l].kind;
+		var ctr = parseInt(elems[l].counter);
+		var error = elems[l].error;
+		var has_img = elems[l].has_img;
+		var updated = elems[l].updated;
+		var auxctr = parseInt(elems[l].auxcounter);
 
-			if (id == "subscribed-feeds") {
-				/* feeds_found = ctr; */
-				continue;
-			}
+		if (id == "global-unread") {
+			global_unread = ctr;
+			updateTitle();
+			continue;
+		}
 
-			/*if (getFeedUnread(id, (kind == "cat")) != ctr ||
-					(kind == "cat")) {
-			}*/
+		if (id == "subscribed-feeds") {
+			/* feeds_found = ctr; */
+			continue;
+		}
 
-			setFeedUnread(id, (kind == "cat"), ctr);
-			setFeedValue(id, (kind == "cat"), 'auxcounter', auxctr);
+		/*if (getFeedUnread(id, (kind == "cat")) != ctr ||
+				(kind == "cat")) {
+		}*/
 
-			if (kind != "cat") {
-				setFeedValue(id, false, 'error', error);
-				setFeedValue(id, false, 'updated', updated);
+		setFeedUnread(id, (kind == "cat"), ctr);
+		setFeedValue(id, (kind == "cat"), 'auxcounter', auxctr);
 
-				if (id > 0) {
-					if (has_img) {
-						setFeedIcon(id, false,
-							getInitParam("icons_url") + "/" + id + ".ico");
-					} else {
-						setFeedIcon(id, false, 'images/blank_icon.gif');
-					}
+		if (kind != "cat") {
+			setFeedValue(id, false, 'error', error);
+			setFeedValue(id, false, 'updated', updated);
+
+			if (id > 0) {
+				if (has_img) {
+					setFeedIcon(id, false,
+						getInitParam("icons_url") + "/" + id + ".ico");
+				} else {
+					setFeedIcon(id, false, 'images/blank_icon.gif');
 				}
 			}
 		}
+	}
 
-		hideOrShowFeeds(getInitParam("hide_read_feeds") == 1);
-
-		_counters_prev = elems;
+	hideOrShowFeeds(getInitParam("hide_read_feeds") == 1);
 
-	} catch (e) {
-		exception_error("parse_counters", e);
-	}
+	_counters_prev = elems;
 }
 
 function getFeedUnread(feed, is_cat) {
@@ -405,15 +373,10 @@ function getFeedValue(feed, is_cat, key) {
 }
 
 function setFeedUnread(feed, is_cat, unread) {
-	try {
-		var tree = dijit.byId("feedTree");
-
-		if (tree && tree.model)
-			return tree.model.setFeedUnread(feed, is_cat, unread);
+	var tree = dijit.byId("feedTree");
 
-	} catch (e) {
-		exception_error("setFeedUnread", e);
-	}
+	if (tree && tree.model)
+		return tree.model.setFeedUnread(feed, is_cat, unread);
 }
 
 function setFeedValue(feed, is_cat, key, value) {
@@ -429,50 +392,31 @@ function setFeedValue(feed, is_cat, key, value) {
 }
 
 function selectFeed(feed, is_cat) {
-	try {
-		var tree = dijit.byId("feedTree");
-
-		if (tree) return tree.selectFeed(feed, is_cat);
+	var tree = dijit.byId("feedTree");
 
-	} catch (e) {
-		exception_error("selectFeed", e);
-	}
+	if (tree) return tree.selectFeed(feed, is_cat);
 }
 
 function setFeedIcon(feed, is_cat, src) {
-	try {
-		var tree = dijit.byId("feedTree");
-
-		if (tree) return tree.setFeedIcon(feed, is_cat, src);
+	var tree = dijit.byId("feedTree");
 
-	} catch (e) {
-		exception_error("setFeedIcon", e);
-	}
+	if (tree) return tree.setFeedIcon(feed, is_cat, src);
 }
 
 function setFeedExpandoIcon(feed, is_cat, src) {
-	try {
-		var tree = dijit.byId("feedTree");
+	var tree = dijit.byId("feedTree");
 
-		if (tree) return tree.setFeedExpandoIcon(feed, is_cat, src);
+	if (tree) return tree.setFeedExpandoIcon(feed, is_cat, src);
 
-	} catch (e) {
-		exception_error("setFeedIcon", e);
-	}
 	return false;
 }
 
 function getNextUnreadFeed(feed, is_cat) {
-	try {
-		var tree = dijit.byId("feedTree");
-		var nuf = tree.model.getNextUnreadFeed(feed, is_cat);
-
-		if (nuf)
-			return tree.model.store.getValue(nuf, 'bare_id');
+	var tree = dijit.byId("feedTree");
+	var nuf = tree.model.getNextUnreadFeed(feed, is_cat);
 
-	} catch (e) {
-		exception_error("getNextUnreadFeed", e);
-	}
+	if (nuf)
+		return tree.model.store.getValue(nuf, 'bare_id');
 }
 
 function catchupCurrentFeed(mode) {
@@ -480,152 +424,138 @@ function catchupCurrentFeed(mode) {
 }
 
 function catchupFeedInGroup(id) {
-	try {
-
-		var title = getFeedName(id);
+	var title = getFeedName(id);
 
-		var str = __("Mark all articles in %s as read?").replace("%s", title);
+	var str = __("Mark all articles in %s as read?").replace("%s", title);
 
-		if (getInitParam("confirm_feed_catchup") != 1 || confirm(str)) {
+	if (getInitParam("confirm_feed_catchup") != 1 || confirm(str)) {
 
-			var rows = $$("#headlines-frame > div[id*=RROW][data-orig-feed-id='"+id+"']");
+		var rows = $$("#headlines-frame > div[id*=RROW][data-orig-feed-id='"+id+"']");
 
-			if (rows.length > 0) {
+		if (rows.length > 0) {
 
-				rows.each(function (row) {
-					row.removeClassName("Unread");
+			rows.each(function (row) {
+				row.removeClassName("Unread");
 
-					if (row.getAttribute("data-article-id") != getActiveArticleId()) {
-						new Effect.Fade(row, {duration: 0.5});
-					}
-
-				});
+				if (row.getAttribute("data-article-id") != getActiveArticleId()) {
+					new Effect.Fade(row, {duration: 0.5});
+				}
 
-				var feedTitles = $$("#headlines-frame > div[class='cdmFeedTitle']");
+			});
 
-				for (var i = 0; i < feedTitles.length; i++) {
-					if (feedTitles[i].getAttribute("data-feed-id") == id) {
+			var feedTitles = $$("#headlines-frame > div[class='cdmFeedTitle']");
 
-						if (i < feedTitles.length - 1) {
-							new Effect.Fade(feedTitles[i], {duration: 0.5});
-						}
+			for (var i = 0; i < feedTitles.length; i++) {
+				if (feedTitles[i].getAttribute("data-feed-id") == id) {
 
-						break;
+					if (i < feedTitles.length - 1) {
+						new Effect.Fade(feedTitles[i], {duration: 0.5});
 					}
-				}
 
-				updateFloatingTitle(true);
+					break;
+				}
 			}
 
-			var catchup_query = "?op=rpc&method=catchupFeed&feed_id=" +
-					id + "&is_cat=false";
+			updateFloatingTitle(true);
+		}
 
-			console.log(catchup_query);
+		var catchup_query = "?op=rpc&method=catchupFeed&feed_id=" +
+				id + "&is_cat=false";
 
-			notify_progress("Loading, please wait...", true);
+		console.log(catchup_query);
 
-			new Ajax.Request("backend.php", {
-				parameters: catchup_query,
-				onComplete: function (transport) {
-					handle_rpc_json(transport);
-				}
-			} );
+		notify_progress("Loading, please wait...", true);
 
-			//return viewCurrentFeed('MarkAllReadGR:' + id);
-		}
+		new Ajax.Request("backend.php", {
+			parameters: catchup_query,
+			onComplete: function (transport) {
+				handle_rpc_json(transport);
+			}
+		} );
 
-	} catch (e) {
-		exception_error("catchupFeedInGroup", e);
+		//return viewCurrentFeed('MarkAllReadGR:' + id);
 	}
 }
 
 function catchupFeed(feed, is_cat, mode) {
-	try {
-		if (is_cat == undefined) is_cat = false;
-
-		var str = false;
-
-		switch (mode) {
-		case "1day":
-			str = __("Mark all articles in %s older than 1 day as read?");
-			break;
-		case "1week":
-			str = __("Mark all articles in %s older than 1 week as read?");
-			break;
-		case "2week":
-			str = __("Mark all articles in %s older than 2 weeks as read?");
-			break;
-		default:
-			str = __("Mark all articles in %s as read?");
-		}
+	if (is_cat == undefined) is_cat = false;
+
+	var str = false;
+
+	switch (mode) {
+	case "1day":
+		str = __("Mark all articles in %s older than 1 day as read?");
+		break;
+	case "1week":
+		str = __("Mark all articles in %s older than 1 week as read?");
+		break;
+	case "2week":
+		str = __("Mark all articles in %s older than 2 weeks as read?");
+		break;
+	default:
+		str = __("Mark all articles in %s as read?");
+	}
 
-		var fn = getFeedName(feed, is_cat);
+	var fn = getFeedName(feed, is_cat);
 
-		str = str.replace("%s", fn);
+	str = str.replace("%s", fn);
 
-		if (getInitParam("confirm_feed_catchup") == 1 && !confirm(str)) {
-			return;
-		}
+	if (getInitParam("confirm_feed_catchup") == 1 && !confirm(str)) {
+		return;
+	}
 
-		var catchup_query = "?op=rpc&method=catchupFeed&feed_id=" +
-			feed + "&is_cat=" + is_cat + "&mode=" + mode;
+	var catchup_query = "?op=rpc&method=catchupFeed&feed_id=" +
+		feed + "&is_cat=" + is_cat + "&mode=" + mode;
 
-		console.log(catchup_query);
+	console.log(catchup_query);
 
-		notify_progress("Loading, please wait...", true);
+	notify_progress("Loading, please wait...", true);
 
-		new Ajax.Request("backend.php",	{
-			parameters: catchup_query,
-			onComplete: function(transport) {
-					handle_rpc_json(transport);
+	new Ajax.Request("backend.php",	{
+		parameters: catchup_query,
+		onComplete: function(transport) {
+				handle_rpc_json(transport);
 
-					var show_next_feed = getInitParam("on_catchup_show_next_feed") == "1";
+				var show_next_feed = getInitParam("on_catchup_show_next_feed") == "1";
 
-					if (show_next_feed) {
-						var nuf = getNextUnreadFeed(feed, is_cat);
+				if (show_next_feed) {
+					var nuf = getNextUnreadFeed(feed, is_cat);
 
-						if (nuf) {
-							viewfeed({feed: nuf, is_cat: is_cat});
-						}
-					} else {
-						if (feed == getActiveFeedId() && is_cat == activeFeedIsCat()) {
-							viewCurrentFeed();
-						}
+					if (nuf) {
+						viewfeed({feed: nuf, is_cat: is_cat});
 					}
+				} else {
+					if (feed == getActiveFeedId() && is_cat == activeFeedIsCat()) {
+						viewCurrentFeed();
+					}
+				}
 
-					notify("");
-				} });
+				notify("");
+			} });
 
-	} catch (e) {
-		exception_error("catchupFeed", e);
-	}
 }
 
 function decrementFeedCounter(feed, is_cat) {
-	try {
-		var ctr = getFeedUnread(feed, is_cat);
+	var ctr = getFeedUnread(feed, is_cat);
 
-		if (ctr > 0) {
-			setFeedUnread(feed, is_cat, ctr - 1);
-			global_unread = global_unread - 1;
-			updateTitle();
+	if (ctr > 0) {
+		setFeedUnread(feed, is_cat, ctr - 1);
+		global_unread = global_unread - 1;
+		updateTitle();
 
-			if (!is_cat) {
-				var cat = parseInt(getFeedCategory(feed));
+		if (!is_cat) {
+			var cat = parseInt(getFeedCategory(feed));
 
-				if (!isNaN(cat)) {
-					ctr = getFeedUnread(cat, true);
+			if (!isNaN(cat)) {
+				ctr = getFeedUnread(cat, true);
 
-					if (ctr > 0) {
-						setFeedUnread(cat, true, ctr - 1);
-					}
+				if (ctr > 0) {
+					setFeedUnread(cat, true, ctr - 1);
 				}
 			}
 		}
-
-	} catch (e) {
-		exception_error("decrement_feed_counter", e);
 	}
+
 }
 
 
-- 
cgit v1.2.3