From 21ce7d9ec02b0bf7c6e0ac7c28bc7c1bb0a841c5 Mon Sep 17 00:00:00 2001 From: Andrew Dolgov Date: Wed, 26 Apr 2017 20:57:36 +0300 Subject: update phpmd ruleset to use (subset) of cleancode fix various minor issues reported by static analysis remove redundant php closing tag from several more files --- plugins/af_comics/filters/af_comics_pa.php | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) (limited to 'plugins/af_comics/filters/af_comics_pa.php') diff --git a/plugins/af_comics/filters/af_comics_pa.php b/plugins/af_comics/filters/af_comics_pa.php index 0848adbd0..ae5cabec0 100644 --- a/plugins/af_comics/filters/af_comics_pa.php +++ b/plugins/af_comics/filters/af_comics_pa.php @@ -8,16 +8,13 @@ class Af_Comics_Pa extends Af_ComicFilter { function process(&$article) { if (strpos($article["link"], "penny-arcade.com") !== FALSE && strpos($article["title"], "Comic:") !== FALSE) { - if ($debug_enabled) { + /*if ($debug_enabled) { _debug("af_pennyarcade: Processing comic"); - } + }*/ $doc = new DOMDocument(); - $doc->loadHTML(fetch_file_contents($article["link"])); - - $basenode = false; - if ($doc) { + if ($doc->loadHTML(fetch_file_contents($article["link"]))) { $xpath = new DOMXPath($doc); $basenode = $xpath->query('(//div[@id="comicFrame"])')->item(0); @@ -30,13 +27,12 @@ class Af_Comics_Pa extends Af_ComicFilter { } if (strpos($article["link"], "penny-arcade.com") !== FALSE && strpos($article["title"], "News Post:") !== FALSE) { - if ($debug_enabled) { + /*if ($debug_enabled) { _debug("af_pennyarcade: Processing news post"); - } + }*/ $doc = new DOMDocument(); - $doc->loadHTML(fetch_file_contents($article["link"])); - if ($doc) { + if ($doc->loadHTML(fetch_file_contents($article["link"]))) { $xpath = new DOMXPath($doc); $entries = $xpath->query('(//div[@class="post"])'); @@ -75,5 +71,4 @@ class Af_Comics_Pa extends Af_ComicFilter { return false; } -} -?> +} \ No newline at end of file -- cgit v1.2.3