From 297a89c2d220860f08e0c30356adfefe2cfa22cd Mon Sep 17 00:00:00 2001 From: koffieanon Date: Sat, 4 Jan 2020 17:20:33 +0100 Subject: Fix bug processing found due to operator precedence. --- plugins/af_redditimgur/init.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'plugins/af_redditimgur/init.php') diff --git a/plugins/af_redditimgur/init.php b/plugins/af_redditimgur/init.php index c8ba4a1b2..555cb0710 100755 --- a/plugins/af_redditimgur/init.php +++ b/plugins/af_redditimgur/init.php @@ -239,10 +239,10 @@ class Af_RedditImgur extends Plugin { } $matches = array(); - if (!$found && preg_match("/youtube\.com\/v\/([\w-]+)/", $entry->getAttribute("href"), $matches) || + if (!$found && (preg_match("/youtube\.com\/v\/([\w-]+)/", $entry->getAttribute("href"), $matches) || preg_match("/youtube\.com\/.*?[\&\?]v=([\w-]+)/", $entry->getAttribute("href"), $matches) || preg_match("/youtube\.com\/watch\?v=([\w-]+)/", $entry->getAttribute("href"), $matches) || - preg_match("/\/\/youtu.be\/([\w-]+)/", $entry->getAttribute("href"), $matches)) { + preg_match("/\/\/youtu.be\/([\w-]+)/", $entry->getAttribute("href"), $matches))) { $vid_id = $matches[1]; @@ -264,9 +264,9 @@ class Af_RedditImgur extends Plugin { $found = true; } - if (!$found && preg_match("/\.(jpg|jpeg|gif|png)(\?[0-9][0-9]*)?$/i", $entry->getAttribute("href")) || + if (!$found && (preg_match("/\.(jpg|jpeg|gif|png)(\?[0-9][0-9]*)?$/i", $entry->getAttribute("href")) || mb_strpos($entry->getAttribute("href"), "i.reddituploads.com") !== FALSE || - mb_strpos($this->get_content_type($entry->getAttribute("href")), "image/") !== FALSE) { + mb_strpos($this->get_content_type($entry->getAttribute("href")), "image/") !== FALSE)) { Debug::log("Handling as a picture", Debug::$LOG_VERBOSE); -- cgit v1.2.3 From e89dd83f05c6307686bae0a689028c6aba8e87a0 Mon Sep 17 00:00:00 2001 From: koffieanon Date: Sat, 4 Jan 2020 17:21:05 +0100 Subject: Spaces to tabs for consistency. --- plugins/af_redditimgur/init.php | 42 ++++++++++++++++++++--------------------- 1 file changed, 21 insertions(+), 21 deletions(-) (limited to 'plugins/af_redditimgur/init.php') diff --git a/plugins/af_redditimgur/init.php b/plugins/af_redditimgur/init.php index 555cb0710..6db194106 100755 --- a/plugins/af_redditimgur/init.php +++ b/plugins/af_redditimgur/init.php @@ -280,36 +280,36 @@ class Af_RedditImgur extends Plugin { $found = true; } - // imgur via link rel="image_src" href="..." - if (!$found && preg_match("/imgur/", $entry->getAttribute("href"))) { + // imgur via link rel="image_src" href="..." + if (!$found && preg_match("/imgur/", $entry->getAttribute("href"))) { - Debug::log("handling as imgur page/whatever", Debug::$LOG_VERBOSE); + Debug::log("handling as imgur page/whatever", Debug::$LOG_VERBOSE); - $content = fetch_file_contents(["url" => $entry->getAttribute("href"), - "http_accept" => "text/*"]); + $content = fetch_file_contents(["url" => $entry->getAttribute("href"), + "http_accept" => "text/*"]); - if ($content) { - $cdoc = new DOMDocument(); + if ($content) { + $cdoc = new DOMDocument(); - if (@$cdoc->loadHTML($content)) { - $cxpath = new DOMXPath($cdoc); + if (@$cdoc->loadHTML($content)) { + $cxpath = new DOMXPath($cdoc); - $rel_image = $cxpath->query("//link[@rel='image_src']")->item(0); + $rel_image = $cxpath->query("//link[@rel='image_src']")->item(0); - if ($rel_image) { + if ($rel_image) { - $img = $doc->createElement('img'); - $img->setAttribute("src", $rel_image->getAttribute("href")); + $img = $doc->createElement('img'); + $img->setAttribute("src", $rel_image->getAttribute("href")); - $br = $doc->createElement('br'); - $entry->parentNode->insertBefore($img, $entry); - $entry->parentNode->insertBefore($br, $entry); + $br = $doc->createElement('br'); + $entry->parentNode->insertBefore($img, $entry); + $entry->parentNode->insertBefore($br, $entry); - $found = true; - } - } - } - } + $found = true; + } + } + } + } // wtf is this even if (!$found && preg_match("/^https?:\/\/gyazo\.com\/([^\.\/]+$)/", $entry->getAttribute("href"), $matches)) { -- cgit v1.2.3 From 3a3c74dfa42abd2fcd66b40f55675f5942ea0794 Mon Sep 17 00:00:00 2001 From: koffieanon Date: Sat, 4 Jan 2020 17:22:58 +0100 Subject: Also match images with query string (size, tokens, etc). --- plugins/af_redditimgur/init.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'plugins/af_redditimgur/init.php') diff --git a/plugins/af_redditimgur/init.php b/plugins/af_redditimgur/init.php index 6db194106..d28e072f4 100755 --- a/plugins/af_redditimgur/init.php +++ b/plugins/af_redditimgur/init.php @@ -264,7 +264,7 @@ class Af_RedditImgur extends Plugin { $found = true; } - if (!$found && (preg_match("/\.(jpg|jpeg|gif|png)(\?[0-9][0-9]*)?$/i", $entry->getAttribute("href")) || + if (!$found && (preg_match("/\.(jpg|jpeg|gif|png)(\?[0-9][0-9]*)?[$\?]/i", $entry->getAttribute("href")) || mb_strpos($entry->getAttribute("href"), "i.reddituploads.com") !== FALSE || mb_strpos($this->get_content_type($entry->getAttribute("href")), "image/") !== FALSE)) { -- cgit v1.2.3