Browse Source

setScore, selectionSetScore: check for numerical values properly

Andrew Dolgov 2 months ago
parent
commit
781fe3d636
1 changed files with 3 additions and 3 deletions
  1. 3 3
      js/Article.js

+ 3 - 3
js/Article.js

@@ -32,7 +32,7 @@ define(["dojo/_base/declare"], function (declare) {
 			if (ids.length > 0) {
 				const score = prompt(__("Please enter new score for selected articles:"));
 
-				if (parseInt(score) != undefined) {
+				if (!isNaN(parseInt(score))) {
 					ids.each((id) => {
 						const row = $("RROW-" + id);
 
@@ -66,7 +66,7 @@ define(["dojo/_base/declare"], function (declare) {
 				const score_old = row.getAttribute("data-score");
 				const score = prompt(__("Please enter new score for this article:"), score_old);
 
-				if (parseInt(score) != undefined) {
+				if (!isNaN(parseInt(score))) {
 					row.setAttribute("data-score", score);
 
 					const pic = row.select(".icon-score")[0];
@@ -340,4 +340,4 @@ define(["dojo/_base/declare"], function (declare) {
 	}
 
 	return Article;
-});
+});