#69 Use primary keys on all database tables

Closed
VannTen wants to merge 0 commits from deleted into fox/master
VannTen commented 1 year ago

Hi there.

I recently encountered a small trouble on my TTRSS deployment. It runs with a Percona Mysql backend. When Percona pxc_strict_mode is enabled, DML operations are forbidden on tables without primary keys.

I did a little digging and found that thread in the old forums. So I followed your recommendations here and made that pull request.

Please let me know if there is anything needing improvements or reformating.

Thank you.

Hi there. I recently encountered a small trouble on my TTRSS deployment. It runs with a Percona Mysql backend. When Percona `pxc_strict_mode` is enabled, DML operations are forbidden on tables without primary keys. I did a little digging and found that [thread](https://tt-rss.org/oldforum/viewtopic.php?t=3070) in the old forums. So I followed your recommendations here and made that pull request. Please let me know if there is anything needing improvements or reformating. Thank you.
fox commented 1 year ago
Owner
  1. i'm not sure mysql and postgres having different columns is the best idea.
  2. adding so many id fields everywhere can introduce issues i'm going to have trouble debugging because i don't really run mysql anymore
  3. making so many changes because of some mysql vendor or whatever "percona" is having random retarded requirements doesn't sound like a very wise idea

i think this is best left outside of trunk.

in short: use postgres.

1. i'm not sure mysql and postgres having different columns is the best idea. 2. adding so many id fields everywhere can introduce issues i'm going to have trouble debugging because i don't really run mysql anymore 3. making so many changes because of some mysql vendor or whatever "percona" is having random retarded requirements doesn't sound like a very wise idea i think this is best left outside of trunk. in short: use postgres.
fox commented 1 year ago
Owner

i've just noticed that you've also updated postgres schema file so point 1 can be ignored, i suppose.

i've just noticed that you've also updated postgres schema file so point 1 can be ignored, i suppose.
VannTen commented 1 year ago
Poster

Noted.

Thanks for your quick reply.

Noted. Thanks for your quick reply.
Please reopen this pull request to perform merge operation.
Sign in to join this conversation.
No Label
No Milestone
No assignee
2 Participants
Loading...
Cancel
Save
There is no content yet.