#71 Update af_lang_detect plugin to current upstream Text_LanguageDetect version

Merged
fox merged 1 commits from tschuettler/update-language-detect-plugin into fox/master 1 year ago

https://github.com/pear/Text_LanguageDetect/compare/v0.3.0...v1.0.0

Update reasons: https://github.com/pear/Text_LanguageDetect/commit/53f9c7a8cd3656975cb187573ea4f5dde9ccb8ca to stop the entry Methods with the same name as their class will not be constructors in a future version of PHP; Text_LanguageDetect_Parser has a deprecated constructor from flooding the error log.

Language detection seemed unreliable https://github.com/pear/Text_LanguageDetect/commit/f37126e58507df5348d14002821fa00f7c9e838a

I tried to reapply the downstream changes to pass your phpmd ruleset. Perhaps the suppression of warnings is not even nesseccary anymore.

I moved the file LanguageDetect.php to its upstream location.

https://github.com/pear/Text_LanguageDetect/compare/v0.3.0...v1.0.0 Update reasons: https://github.com/pear/Text_LanguageDetect/commit/53f9c7a8cd3656975cb187573ea4f5dde9ccb8ca to stop the entry ```Methods with the same name as their class will not be constructors in a future version of PHP; Text_LanguageDetect_Parser has a deprecated constructor``` from flooding the error log. Language detection seemed unreliable https://github.com/pear/Text_LanguageDetect/commit/f37126e58507df5348d14002821fa00f7c9e838a I tried to reapply the downstream changes to pass your phpmd ruleset. Perhaps the suppression of warnings is not even nesseccary anymore. I moved the file `LanguageDetect.php` to its upstream location.
tschuettler commented 1 year ago
Poster

It looks to me like moving the file did not survive the pull request. Any idea how to fix that?

It looks to me like moving the file did not survive the pull request. Any idea how to fix that?
fox commented 1 year ago
Owner

isn't it just a bunch of git changesets? maybe you forgot one?

honestly no idea though, i just merge them :)

isn't it just a bunch of git changesets? maybe you forgot one? honestly no idea though, i just merge them :)
tschuettler commented 1 year ago
Poster

I expected to see something like in this PR: LanguageDetect.php → Text/LanguageDetect.php

However the show file link under files https://git.tt-rss.org/tschuettler/tt-rss/src/31b40448fd4a08032f562ce171a66c6952370f60/plugins/af_lang_detect/languagedetect/LanguageDetect.php results in a 404 whereas https://git.tt-rss.org/tschuettler/tt-rss/src/31b40448fd4a08032f562ce171a66c6952370f60/plugins/af_lang_detect/languagedetect/Text/LanguageDetect.php is fine, as my branch is looking good.

So perhaps it's all just fine and it's just a gogs thing.

I expected to see something like in this PR: ```LanguageDetect.php → Text/LanguageDetect.php``` However the show file link under files https://git.tt-rss.org/tschuettler/tt-rss/src/31b40448fd4a08032f562ce171a66c6952370f60/plugins/af_lang_detect/languagedetect/LanguageDetect.php results in a 404 whereas https://git.tt-rss.org/tschuettler/tt-rss/src/31b40448fd4a08032f562ce171a66c6952370f60/plugins/af_lang_detect/languagedetect/Text/LanguageDetect.php is fine, as my branch is looking good. So perhaps it's all just fine and it's just a gogs thing.
fox commented 1 year ago
Owner

i'll try to take a closer look (i.e. merge into a separate branch manually) tomorrow

i'll try to take a closer look (i.e. merge into a separate branch manually) tomorrow
fox commented 1 year ago
Owner

well, the files seem to be in place as far as i can see.

since there's namespace-aware loader for vendor/ maybe actual library should be moved there instead of relying on require_once hacks but it's not really necessary (besides it's a plugin dependency).

sorry for the delay.

well, the files seem to be in place as far as i can see. since there's namespace-aware loader for vendor/ maybe actual library should be moved there instead of relying on require_once hacks but it's not really necessary (besides it's a plugin dependency). sorry for the delay.
tschuettler commented 1 year ago
Poster

thanks a lot!

thanks a lot!
This pull request has been merged successfully!
Sign in to join this conversation.
No Label
No Milestone
No assignee
2 Participants
Loading...
Cancel
Save
There is no content yet.