#2 Use submodule instead of a raw copy of sources?

Closed
opened 3 months ago by Ezwen · 2 comments
Ezwen commented 3 months ago

Currently this plugin contains a complete copy of PHPMailer in its git repository.

Question: why not using a git submodule to keep track of a specific version of the official PHPMailer repository? I believe that it would make it easier to upgrade PHPMailer in the ttrss-mailer-smtp plugin (simple bump on the submodule).

The documentation would have to be adapted though, as a clone of ttrss-mailer-smtp would not be enough anymore. Either git clone --recurse-submodules or git submodule update --init should be used by users.

Currently this plugin contains a complete copy of PHPMailer in its git repository. **Question:** why not using a git submodule to keep track of a specific version of the official PHPMailer repository? I believe that it would make it easier to upgrade PHPMailer in the *ttrss-mailer-smtp* plugin (simple bump on the submodule). The documentation would have to be adapted though, as a clone of *ttrss-mailer-smtp* would not be enough anymore. Either `git clone --recurse-submodules` or `git submodule update --init` should be used by users.
fox commented 3 months ago
Owner

Question: why not using a git submodule to keep track of a specific version of the official PHPMailer repository?

what if official phpmailer repository becomes blocked tomorrow in your country (assuming it's not the US) for whatever reason

what if phpmailer decides to move their repository elsewhere or get banned on github, which is a third party commercial service which may ban anyone for any reason

etc, etc

>Question: why not using a git submodule to keep track of a specific version of the official PHPMailer repository? what if official phpmailer repository becomes blocked tomorrow in your country (assuming it's not the US) for whatever reason what if phpmailer decides to move their repository elsewhere or get banned on github, which is a third party commercial service which may ban anyone for any reason etc, etc
Ezwen commented 3 months ago
Poster

Fair point, understood. Thanks for answering.

Fair point, understood. Thanks for answering.
Sign in to join this conversation.
No Label
No Milestone
No assignee
2 Participants
Loading...
Cancel
Save
There is no content yet.