#4 Add 3 comparison options for PGSQL (bit_count extension, user function, or direct compare).

Closed
rodneys_mission wants to merge 0 commits from deleted into fox/master

I added a variable "pg_method" to the plugin storage/params. 1 = use compiled extension, 2 = use sql function, 3 = direct compare. Added html to prefs screen to select. Added auto-detect on prefs screen when uninitialized. Apropos messages along the way. In the article render method, return article if no pg_method selected instead of if bit_count does not exist.

Note: for some reason this still has the "SUBSTRING_FOR_DATE" fix. I guess I didn't merge that into my master branch. : /

Thoughts? R

I added a variable "pg_method" to the plugin storage/params. 1 = use compiled extension, 2 = use sql function, 3 = direct compare. Added html to prefs screen to select. Added auto-detect on prefs screen when uninitialized. Apropos messages along the way. In the article render method, return article if no pg_method selected instead of if bit_count does not exist. Note: for some reason this still has the "SUBSTRING_FOR_DATE" fix. I guess I didn't merge that into my master branch. : / Thoughts? R
fox commented 2 months ago
Owner

This pull request can't be merged automatically because there are conflicts.

you'll have to rebase to master and resubmit

> This pull request can't be merged automatically because there are conflicts. you'll have to rebase to master and resubmit
fox commented 2 months ago
Owner

also,

1) this should be a config.php define, there's no point to have this as a user-configurable option because there's zero sense in it being different per-user

2) i'm looking through the source and it's a whole bunch of bloat, you've added like 3 different functions including an absolutely useless direct phash comparison which entirely defeats the point of this plugin

your pull request is terrible. please don't resubmit this.

if you really want to, host this on github or something. i'm not accepting this.

also, 1) this should be a config.php define, there's no point to have this as a user-configurable option because there's zero sense in it being different per-user 2) i'm looking through the source and it's a whole bunch of bloat, you've added like 3 different functions including an absolutely useless direct phash comparison which entirely defeats the point of this plugin your pull request is terrible. please don't resubmit this. if you really want to, host this on github or something. i'm not accepting this.
rodneys_mission commented 2 months ago
Poster

ok.

ok.
Please reopen this pull request to perform merge operation.
Sign in to join this conversation.
No Label
No Milestone
No assignee
2 Participants
Loading...
Cancel
Save
There is no content yet.