lllusion3418

lllusion3418 commented on issue fox/tt-rss#133

Fix media cache url rewriting for videos with both poster and src

I haven't explicitly tested everything yet, but I added poster downloading, `video[@src]` and I changed it to a foreach (force push).

6 months ago

lllusion3418 pushed to cache_videos_with_src_and_poster at lllusion3418/tt-rss

  • ec1b0befc7 add support for video[@src] in media cache it's a valid alternative to a source[@src] child element: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/video
  • cdde23b4dc actually download <video> posters to media cache video[@poster] is already supported in the rewriting logic but never actually downloaded
  • b4287a2e98 fix url rewriting for videos with poster and src if a poster attribute was present only that would have been rewritten and the (arguably more important) src attribute would be left as-is
  • ae751eb7fb add support for video[@src] in media cache it's a valid alternative to a source[@src] child element: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/video
  • 74cc076460 actually download <video> posters to media cache video[@poster] is already supported in the rewriting logic but never actually downloaded
  • View comparison for these 6 commits »

6 months ago

lllusion3418 pushed to cache_videos_with_src_and_poster at lllusion3418/tt-rss

  • ae751eb7fb add support for video[@src] in media cache it's a valid alternative to a source[@src] child element: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/video
  • 74cc076460 actually download <video> posters to media cache video[@poster] is already supported in the rewriting logic but never actually downloaded
  • 79cc698c3a fix url rewriting for videos with poster and src if a poster attribute was present only that would have been rewritten and the (arguably more important) src attribute would be left as-is
  • ba8903cf8d fix url rewriting for videos with poster and src if a poster attribute was present only that would have been rewritten and the (arguably more important) src attribute would be left as-is
  • View comparison for these 4 commits »

6 months ago

lllusion3418 commented on issue fox/tt-rss#133

Fix media cache url rewriting for videos with both poster and src

Yes, I *really* did (well, I manually typed it), because

6 months ago

lllusion3418 commented on issue fox/tt-rss#133

Fix media cache url rewriting for videos with both poster and src

So I looked a bit further and noticed that it was actually my feed that was messed up: `poster` is only a valid attribute of `<video>`, *not* of `<source>`

6 months ago

lllusion3418 created pull request fox/tt-rss#133

Fix media cache url rewriting for videos with both poster and src

6 months ago

lllusion3418 pushed to cache_videos_with_src_and_poster at lllusion3418/tt-rss

  • ba8903cf8d fix url rewriting for videos with poster and src if a poster attribute was present only that would have been rewritten and the (arguably more important) src attribute would be left as-is
  • 4e27d10ebc fix url rewriting for videos with poster and src if a poster attribute was present only that would have been rewritten and the (arguably more important) src attribute would be left as-is
  • View comparison for these 2 commits »

6 months ago

lllusion3418 pushed to cache_videos_with_src_and_poster at lllusion3418/tt-rss

  • 4e27d10ebc fix url rewriting for videos with poster and src if a poster attribute was present only that would have been rewritten and the (arguably more important) src attribute would be left as-is
  • 208e02c47d PluginHost/save_data: use separate PDO connection to prevent issues with nested transactions
  • da926067ab Merge branch 'get-version-git-on-windows' of tsimmons/tt-rss into master
  • 569228a5df In get_version() disable DIRECTORY_SEPARATOR check, permit using git on Windows to get version details;
  • 8ad523fcec do not keep current feed visible when hide as read is enabled

6 months ago

lllusion3418 pushed to master at lllusion3418/tt-rss

  • 208e02c47d PluginHost/save_data: use separate PDO connection to prevent issues with nested transactions
  • da926067ab Merge branch 'get-version-git-on-windows' of tsimmons/tt-rss into master
  • 569228a5df In get_version() disable DIRECTORY_SEPARATOR check, permit using git on Windows to get version details;
  • 8ad523fcec do not keep current feed visible when hide as read is enabled
  • 68562e2618 fix wrong colors applying to rule textarea when invoked from main UI
  • View comparison for these 1210 commits »

6 months ago

lllusion3418 commented on issue fox/tt-rss#98

Fix misplaced bracket in sprintf

Sorry, my comment was a bit of a mess.

1 year ago

lllusion3418 commented on issue fox/tt-rss#98

Fix misplaced bracket in sprintf

Doesn't the [new version](https://git.tt-rss.org/fox/tt-rss/src/d53cdaf815c86bf66a5577f575f76831679ed4f2/classes/rssutils.php#L833) pass `Debug::$LOG_VERBOSE` to `sprintf()` instead of `Debug::log()`?

1 year ago

lllusion3418 commented on issue fox/tt-rss#56

change filter rule regexp type to text

the oldest version in the mysql archives, 5.0.15 behaves identically:

2 years ago

lllusion3418 commented on issue fox/tt-rss#55

Increase reg_exp length

you also forgot to change the schema version in `functions.php:3`, `ttrss_schema_mysql.sql:251`, and `ttrss_schema_pgsql.sql:246`

2 years ago

lllusion3418 created pull request fox/tt-rss#56

change filter rule regexp type to text

2 years ago

lllusion3418 pushed to reg_exp_length at lllusion3418/tt-rss

  • 2008ec4ed7 change filter rule regexp type to text
  • 963c22646b pass tsvector data as a named parameter on article update, remove escaping hacks
  • 4fa64e8446 filter dialog: remove placeholder
  • e794e434da filter dialog: add tooltip re: filter syntax
  • e35a46733f hlClicked: do not set headline selected when ctrl-clicking

2 years ago

lllusion3418 created new branch reg_exp_length at lllusion3418/tt-rss

2 years ago

lllusion3418 forked a repository to lllusion3418/tt-rss

2 years ago

lllusion3418 commented on issue fox/tt-rss#55

Increase reg_exp length

all the php code doesn't seem to require any specific text type

2 years ago

lllusion3418 commented on issue fox/tt-rss#55

Increase reg_exp length

(this pull request might not be the proper place to discuss this)

2 years ago