tkappe

tkappe commented on issue fox/tt-rss#76

Differentiate enclosures based on content type.

Yep, you got that right. Another solution could be to try and distill a content type from the "medium" attribute. I attached a patch that does this.

1 year ago

tkappe created pull request fox/tt-rss#76

Differentiate enclosures based on content type.

1 year ago

tkappe pushed to pullreq-enclosure-content-type at tkappe/tt-rss

  • ac8a0e7dc6 Differentiate enclosures based on content type. Some RSS feeds contain multiple enclosures with the same URL. When the first of these is not recognized as an image, later entries are not added to the database as rows in ttrss_enclosures. This change differentiates enclosures based on their content type, so an entry can have multiple enclosure types with the same URL (but possibly a different content type).
  • 32c0c07cc1 pluginhost: implement basic autoloader for classes bundled with plugins (uses vendor/ layout)
  • c3d57017d3 Merge branch 'update-language-detect-plugin' of tschuettler/tt-rss into master
  • 03fff1e95e Merge branch 'fix_mysql_utf8mb4' of BtbN/tt-rss into master
  • 2b8afd4942 Only strip utf8mb4 if mysql_charset != utf8mb4 If a user has fixed their database properly utf8mb4 works just fine allowing emoji and other 4 byte unicode characters to work.

1 year ago

tkappe created new branch pullreq-enclosure-content-type at tkappe/tt-rss

1 year ago

tkappe commented on issue fox/tt-rss#74

Store language of entries as indicated by the feed

Right - I should have thought of that. I see you have already added a fix. I put an alternative fix on my branch which determines the feed element by simply looking at the parent of the entry element.

1 year ago

tkappe pushed to pullreq-store-language at tkappe/tt-rss

  • 54e943bd97 Better way to find feed element when determining entry language.

1 year ago

tkappe commented on issue fox/tt-rss#74

Store language of entries as indicated by the feed

OK - I implemented sanitization and removed the `do/while`-loop.

1 year ago

tkappe pushed to pullreq-store-language at tkappe/tt-rss

1 year ago

tkappe commented on issue fox/tt-rss#74

Store language of entries as indicated by the feed

Very well, I propose to do the following:

1 year ago

tkappe commented on issue fox/tt-rss#74

Store language of entries as indicated by the feed

I do not consider this an edge case, but rather an issue of correctly implementing and displaying feeds. If the feed indicates that the entry is in a certain language, then surely displaying the item in that language should be baseline functionality?

1 year ago

tkappe created pull request fox/tt-rss#74

Store language of entries as indicated by the feed

1 year ago

tkappe created pull request fox/tt-rss#73

Fix undefined index warning in installation

1 year ago

tkappe pushed to pullreq-store-language at tkappe/tt-rss

  • 22a866edb5 Store language of entries as indicated by the feed.
  • 32c0c07cc1 pluginhost: implement basic autoloader for classes bundled with plugins (uses vendor/ layout)
  • c3d57017d3 Merge branch 'update-language-detect-plugin' of tschuettler/tt-rss into master
  • 03fff1e95e Merge branch 'fix_mysql_utf8mb4' of BtbN/tt-rss into master
  • 2b8afd4942 Only strip utf8mb4 if mysql_charset != utf8mb4 If a user has fixed their database properly utf8mb4 works just fine allowing emoji and other 4 byte unicode characters to work.

1 year ago

tkappe created new branch pullreq-store-language at tkappe/tt-rss

1 year ago

tkappe pushed to pullreq-fix-undefined-index-warning at tkappe/tt-rss

  • 52dbd55c7b Fix undefined index warning in installation.
  • 32c0c07cc1 pluginhost: implement basic autoloader for classes bundled with plugins (uses vendor/ layout)
  • c3d57017d3 Merge branch 'update-language-detect-plugin' of tschuettler/tt-rss into master
  • 03fff1e95e Merge branch 'fix_mysql_utf8mb4' of BtbN/tt-rss into master
  • 2b8afd4942 Only strip utf8mb4 if mysql_charset != utf8mb4 If a user has fixed their database properly utf8mb4 works just fine allowing emoji and other 4 byte unicode characters to work.

1 year ago

tkappe created new branch pullreq-fix-undefined-index-warning at tkappe/tt-rss

1 year ago

tkappe forked a repository to tkappe/tt-rss

1 year ago