Optimize getChildren with array_filter instead of a foreach

1 files changed, 6 insertions, 7 deletions

diff --git a/src/NodeClass/NodeClassTrait.php b/src/NodeClass/NodeClassTrait.php
index bf34d5e..c117691 100644
--- a/src/NodeClass/NodeClassTrait.php
+++ b/src/NodeClass/NodeClassTrait.php
@@ -320,13 +320,12 @@ trait NodeClassTrait
      */
     public function getChildren($filterEmptyDOMText = false)
     {
-        $ret = [];
-        foreach ($this->childNodes as $node) {
-            if ($filterEmptyDOMText && $node->nodeName === '#text' && !trim($node->nodeValue)) {
-                continue;
-            }
-
-            $ret[] = $node;
+        $ret = iterator_to_array($this->childNodes);
+        if ($filterEmptyDOMText) {
+            // Array values is used to discard the key order. Needs to be 0 to whatever without skipping any number
+            $ret = array_values(array_filter($ret, function ($node) {
+                return $node->nodeName !== '#text' || mb_strlen(trim($node->nodeValue));
+            }));
         }
 
         return $ret;